[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Load appwizard templates from files
From: "Milian Wolff" <mail () milianw ! de>
Date: 2012-05-23 19:58:35
Message-ID: 20120523195835.6709.48027 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105009/#review14097
-----------------------------------------------------------
patchwise and ui-wise I think this is fine - whats missing is of course a w=
ay to upload file templates from within kdevelop (or at least a sane way to=
create new templates) - without that, I think this addition is not so usef=
ul yet, is it?
plugins/appwizard/projecttemplatesmodel.cpp
<http://git.reviewboard.kde.org/r/105009/#comment11148>
imo this debug output is not really useful and should be removed before=
landing this patch eventually
- Milian Wolff
On May 23, 2012, 11:46 a.m., Miha =C4=8Can=C4=8Dula wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105009/
> -----------------------------------------------------------
> =
> (Updated May 23, 2012, 11:46 a.m.)
> =
> =
> Review request for KDevelop, Milian Wolff and Alexander Dymo.
> =
> =
> Description
> -------
> =
> Implement loading templates from local file. Lodaded templates are immedi=
ately selected for convenience. Their descriptions are extracted, but their=
icons are not. I will add icon-extraction after the initial code is review=
ed. The archive files are copied to a ~/.kde/share/apps/kdevappwizard/templ=
ates/ where the existing code picks them up. =
> =
> Since I was already adding buttons, I added one for getting new template =
with KNS as well. It shows a download dialog and refreshes the views, but s=
ince no category is defined yet on kde-files.org, it shows all unrelated it=
ems. =
> =
> Note that this code is currently in the "project-templates" branch. I rea=
lize it's not ready to be merged just yet (due to missing functionality), b=
ut I wanted comments regarding the implementation and user interface. =
> =
> PS: The source files in appwizard files list a bunch of contributors, who=
should I add as reviewers?
> =
> =
> Diffs
> -----
> =
> plugins/appwizard/CMakeLists.txt 0e2119197765ad514b8827fda5afe7254f8ea7=
88 =
> plugins/appwizard/kdevappwizard.knsrc PRE-CREATION =
> plugins/appwizard/projectselectionpage.h 745a1efa1d00c2ac4fe215b7242cf2=
ed09981e9e =
> plugins/appwizard/projectselectionpage.cpp 373c66f7e1218858651d38678cc1=
010b4764308a =
> plugins/appwizard/projectselectionpage.ui 7a33fdd2c68831776ea5dc8d7259a=
fa831854a41 =
> plugins/appwizard/projecttemplatesmodel.h cbd91e976e1472dc29d9bc263268b=
f71d86ec229 =
> plugins/appwizard/projecttemplatesmodel.cpp 1fe09efec92d85c71679648408e=
8972b1ddd4971 =
> =
> Diff: http://git.reviewboard.kde.org/r/105009/diff/
> =
> =
> Testing
> -------
> =
> Tested locally, archives shipped with KAppTemplate are loaded successfull=
y. =
> =
> =
> Screenshots
> -----------
> =
> New buttons in template selection
> http://git.reviewboard.kde.org/r/105009/s/575/
> =
> =
> Thanks,
> =
> Miha =C4=8Can=C4=8Dula
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105009/">http://git.reviewboard.kde.org/r/105009/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patchwise and ui-wise I \
think this is fine - whats missing is of course a way to upload file templates from \
within kdevelop (or at least a sane way to create new templates) - without that, I \
think this addition is not so useful yet, is it?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105009/diff/1/?file=65121#file65121line154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/appwizard/projecttemplatesmodel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">QModelIndexList ProjectTemplatesModel::templateIndexes(const QString& \
fileName)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="n">categories</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">imo this \
debug output is not really useful and should be removed before landing this patch \
eventually</pre> </div>
<br />
<p>- Milian</p>
<br />
<p>On May 23rd, 2012, 11:46 a.m., Miha Čančula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Alexander Dymo.</div>
<div>By Miha Čančula.</div>
<p style="color: grey;"><i>Updated May 23, 2012, 11:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement loading templates from local file. Lodaded templates are \
immediately selected for convenience. Their descriptions are extracted, but their \
icons are not. I will add icon-extraction after the initial code is reviewed. The \
archive files are copied to a ~/.kde/share/apps/kdevappwizard/templates/ where the \
existing code picks them up.
Since I was already adding buttons, I added one for getting new template with KNS as \
well. It shows a download dialog and refreshes the views, but since no category is \
defined yet on kde-files.org, it shows all unrelated items.
Note that this code is currently in the "project-templates" branch. I \
realize it's not ready to be merged just yet (due to missing functionality), but \
I wanted comments regarding the implementation and user interface.
PS: The source files in appwizard files list a bunch of contributors, who should I \
add as reviewers?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested locally, archives shipped with KAppTemplate are loaded \
successfully. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/CMakeLists.txt <span style="color: \
grey">(0e2119197765ad514b8827fda5afe7254f8ea788)</span></li>
<li>plugins/appwizard/kdevappwizard.knsrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/appwizard/projectselectionpage.h <span style="color: \
grey">(745a1efa1d00c2ac4fe215b7242cf2ed09981e9e)</span></li>
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: \
grey">(373c66f7e1218858651d38678cc1010b4764308a)</span></li>
<li>plugins/appwizard/projectselectionpage.ui <span style="color: \
grey">(7a33fdd2c68831776ea5dc8d7259afa831854a41)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.h <span style="color: \
grey">(cbd91e976e1472dc29d9bc263268bf71d86ec229)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.cpp <span style="color: \
grey">(1fe09efec92d85c71679648408e8972b1ddd4971)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105009/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105009/s/575/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/23/kdev-appwizard-buttons_400x100.png" \
style="border: 1px black solid;" alt="New buttons in template selection" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic