[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Load appwizard templates from files
From: Miha Čančula <miha.cancula () gmail ! com>
Date: 2012-05-22 12:39:52
Message-ID: 20120522123952.2160.13522 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 22, 2012, 10:36 a.m., Aleix Pol Gonzalez wrote:
> > We won't merge to master some code that is not fully functional. I'd su=
ggest to put it in a branch until then.
> > =
> > Also a screenshot of the new UI would be helpful.
I understand that, it's already in a branch (project-templates). I updated =
the description to reflect that. =
Also, I thought I had already attached a screenshot. Apparently I did somet=
hing wrong, I'll do it as soon as I get home. =
- Miha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105009/#review14036
-----------------------------------------------------------
On May 22, 2012, 12:38 p.m., Miha =C4=8Can=C4=8Dula wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105009/
> -----------------------------------------------------------
> =
> (Updated May 22, 2012, 12:38 p.m.)
> =
> =
> Review request for KDevelop, Milian Wolff and Alexander Dymo.
> =
> =
> Description
> -------
> =
> Implement loading templates from local file. Lodaded templates are immedi=
ately selected for convenience. Their descriptions are extracted, but their=
icons are not. I will add icon-extraction after the initial code is review=
ed. The archive files are copied to a ~/.kde/share/apps/kdevappwizard/templ=
ates/ where the existing code picks them up. =
> =
> Since I was already adding buttons, I added one for getting new template =
with KNS as well. It shows a download dialog and refreshes the views, but s=
ince no category is defined yet on kde-files.org, it shows all unrelated it=
ems. =
> =
> Note that this code is currently in the "project-templates" branch. I rea=
lize it's not ready to be merged just yet (due to missing functionality), b=
ut I wanted comments regarding the implementation and user interface. =
> =
> PS: The source files in appwizard files list a bunch of contributors, who=
should I add as reviewers?
> =
> =
> Diffs
> -----
> =
> plugins/appwizard/CMakeLists.txt 0e2119197765ad514b8827fda5afe7254f8ea7=
88 =
> plugins/appwizard/kdevappwizard.knsrc PRE-CREATION =
> plugins/appwizard/projectselectionpage.h 745a1efa1d00c2ac4fe215b7242cf2=
ed09981e9e =
> plugins/appwizard/projectselectionpage.cpp 373c66f7e1218858651d38678cc1=
010b4764308a =
> plugins/appwizard/projectselectionpage.ui 7a33fdd2c68831776ea5dc8d7259a=
fa831854a41 =
> plugins/appwizard/projecttemplatesmodel.h cbd91e976e1472dc29d9bc263268b=
f71d86ec229 =
> plugins/appwizard/projecttemplatesmodel.cpp 1fe09efec92d85c71679648408e=
8972b1ddd4971 =
> =
> Diff: http://git.reviewboard.kde.org/r/105009/diff/
> =
> =
> Testing
> -------
> =
> Tested locally, archives shipped with KAppTemplate are loaded successfull=
y. =
> =
> =
> Thanks,
> =
> Miha =C4=8Can=C4=8Dula
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105009/">http://git.reviewboard.kde.org/r/105009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 22nd, 2012, 10:36 a.m., <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We won't merge to master some code that is not fully functional. \
I'd suggest to put it in a branch until then.
Also a screenshot of the new UI would be helpful.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I understand that, \
it's already in a branch (project-templates). I updated the description to \
reflect that.
Also, I thought I had already attached a screenshot. Apparently I did something \
wrong, I'll do it as soon as I get home. </pre> <br />
<p>- Miha</p>
<br />
<p>On May 22nd, 2012, 12:38 p.m., Miha Čančula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Alexander Dymo.</div>
<div>By Miha Čančula.</div>
<p style="color: grey;"><i>Updated May 22, 2012, 12:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement loading templates from local file. Lodaded templates are \
immediately selected for convenience. Their descriptions are extracted, but their \
icons are not. I will add icon-extraction after the initial code is reviewed. The \
archive files are copied to a ~/.kde/share/apps/kdevappwizard/templates/ where the \
existing code picks them up.
Since I was already adding buttons, I added one for getting new template with KNS as \
well. It shows a download dialog and refreshes the views, but since no category is \
defined yet on kde-files.org, it shows all unrelated items.
Note that this code is currently in the "project-templates" branch. I \
realize it's not ready to be merged just yet (due to missing functionality), but \
I wanted comments regarding the implementation and user interface.
PS: The source files in appwizard files list a bunch of contributors, who should I \
add as reviewers?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested locally, archives shipped with KAppTemplate are loaded \
successfully. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/CMakeLists.txt <span style="color: \
grey">(0e2119197765ad514b8827fda5afe7254f8ea788)</span></li>
<li>plugins/appwizard/kdevappwizard.knsrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/appwizard/projectselectionpage.h <span style="color: \
grey">(745a1efa1d00c2ac4fe215b7242cf2ed09981e9e)</span></li>
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: \
grey">(373c66f7e1218858651d38678cc1010b4764308a)</span></li>
<li>plugins/appwizard/projectselectionpage.ui <span style="color: \
grey">(7a33fdd2c68831776ea5dc8d7259afa831854a41)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.h <span style="color: \
grey">(cbd91e976e1472dc29d9bc263268bf71d86ec229)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.cpp <span style="color: \
grey">(1fe09efec92d85c71679648408e8972b1ddd4971)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105009/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic