[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: FindQJSON.cmake: Look for parser.h in the right location.
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-05-13 1:02:41
Message-ID: 20120513010241.2407.61844 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104925/#review13759
-----------------------------------------------------------
Just saw that QJson itself also installs a config-module in my version - 0.7.1. No \
idea when this was added and it is a rather basic file (i.e. hardcoded strings from \
the build), but it should be used if present.
Also that file suggests that finding the first qjson/ directory in your case would be \
the correct thing, which means you should be able to pass \
-DQJSON_INCLUDE_DIRS=/path/to/qjson/ to cmake to have it found.
- Andreas Pakulat
On May 12, 2012, 8:18 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104925/
> -----------------------------------------------------------
>
> (Updated May 12, 2012, 8:18 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> QJSON headers are installed into qjson/qjson/<HEADER>. The find_path()
> call, however, was looking for headers in qjson/<HEADER>, which failed.
>
> Passing PATH_SUFFIX is not enough, and given how the headers are used in
> the code, we need to look for qjson/parser.h, not parser.h.
>
>
> Diffs
> -----
>
> cmake/modules/FindQJSON.cmake 002084aefd8e2c1506a0674439cc37bc2539074b
>
> Diff: http://git.reviewboard.kde.org/r/104925/diff/
>
>
> Testing
> -------
>
> qjson was not found here before, and it is after the patch is applied.
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104925/">http://git.reviewboard.kde.org/r/104925/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just saw that QJson \
itself also installs a config-module in my version - 0.7.1. No idea when this was \
added and it is a rather basic file (i.e. hardcoded strings from the build), but it \
should be used if present.
Also that file suggests that finding the first qjson/ directory in your case would be \
the correct thing, which means you should be able to pass \
-DQJSON_INCLUDE_DIRS=/path/to/qjson/ to cmake to have it found.</pre> <br />
<p>- Andreas</p>
<br />
<p>On May 12th, 2012, 8:18 p.m., Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated May 12, 2012, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QJSON headers are installed into qjson/qjson/<HEADER>. The \
find_path() call, however, was looking for headers in qjson/<HEADER>, which \
failed.
Passing PATH_SUFFIX is not enough, and given how the headers are used in
the code, we need to look for qjson/parser.h, not parser.h.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">qjson was not found here before, and it is after the patch is \
applied.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQJSON.cmake <span style="color: \
grey">(002084aefd8e2c1506a0674439cc37bc2539074b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104925/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic