'Re: Review Request: Add missing include to fix the build with recent GCCs.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Add missing include to fix the build with recent GCCs.
From:       "Andreas Pakulat" <apaku () gmx ! de>
Date:       2012-05-13 0:52:25
Message-ID: 20120513005225.32229.12276 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104926/#review13757
-----------------------------------------------------------

Ship it!

Ship It!

- Andreas Pakulat

On May 12, 2012, 8:45 p.m., Raphael Kubo da Costa wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104926/
> -----------------------------------------------------------
> =

> (Updated May 12, 2012, 8:45 p.m.)
> =

> =

> Review request for KDevelop.
> =

> =

> Description
> -------
> =

> Add missing include to fix the build with recent GCCs.
> =

> Include <string.h> so that the definitions for memcpy() and friends
> can be found. Fixes the build with GCC 4.6.3, at least.
> =

> =

> Diffs
> -----
> =

>   util/dbus_socket_transformer/main.cpp f3734b4fac1a7d36bcd1d3645a2956cf8=
36b4948 =

> =

> Diff: http://git.reviewboard.kde.org/r/104926/diff/
> =

> =

> Testing
> -------
> =

> kdevplatform builds with GCC 4.6.3 here with the patch
> =

> =

> Thanks,
> =

> Raphael Kubo da Costa
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104926/">http://git.reviewboard.kde.org/r/104926/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Andreas</p>

<br />
<p>On May 12th, 2012, 8:45 p.m., Raphael Kubo da Costa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Raphael Kubo da Costa.</div>

<p style="color: grey;"><i>Updated May 12, 2012, 8:45 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add missing include to fix the build with recent GCCs.

Include &lt;string.h&gt; so that the definitions for memcpy() and friends
can be found. Fixes the build with GCC 4.6.3, at least.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdevplatform builds with GCC 4.6.3 here with the patch</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>util/dbus_socket_transformer/main.cpp <span style="color: \
grey">(f3734b4fac1a7d36bcd1d3645a2956cf836b4948)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104926/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 