'Re: Review Request: Fixed a great part of the Qt classes krazy checks (replace Qt classes that shoul'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Fixed a great part of the Qt classes krazy checks (replace Qt classes that shoul
From:       "Andreas Pakulat" <apaku () gmx ! de>
Date:       2012-05-02 17:54:20
Message-ID: 20120502175420.18952.86330 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104823/#review13284
-----------------------------------------------------------

Did you verify wether these changes have any side-effects? in general its o=
ften ok to just use the k-classes, butmaybe in some of the cases the use of=
 the Qt version was intentional. A look at the history may also indicate su=
ch decisions.

- Andreas Pakulat

On May 2, 2012, 3:28 p.m., Ghislain Mary wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104823/
> -----------------------------------------------------------
> =

> (Updated May 2, 2012, 3:28 p.m.)
> =

> =

> Review request for KDevelop.
> =

> =

> Description
> -------
> =

> Fixed a great part of the Qt classes krazy checks (replace Qt classes tha=
t should not be used by there KDE counterparts).
> =

> =

> Diffs
> -----
> =

>   documentation/documentationview.cpp 53e05a88cc3b0f6b4a06864c82f85540fd7=
f9243 =

>   plugins/appwizard/projectselectionpage.ui 7a33fdd2c68831776ea5dc8d7259a=
fa831854a41 =

>   plugins/cvs/cvsgenericoutputview.ui 58a273e4d0967dda949b49be964ba579aa8=
9c5f5 =

>   plugins/dashboard/plasmoids/projectfileplasmoid/config.ui d7be64440e21f=
3e988029d40d299560a50e1f0f9 =

>   plugins/execute/projecttargetscombobox.h 154226844e5a3e7f5c40a09bf86ba4=
7d99f5237f =

>   plugins/execute/projecttargetscombobox.cpp 1096093c07408392daef38d6f4e3=
b2884babc8fd =

>   plugins/externalscript/editexternalscript.ui cd747e649148a941a42f81d5d5=
553c6a0bfb7957 =

>   plugins/git/gitmessagehighlighter.h 5d65e7c9401315b16e8f90c0ce2d49e4f49=
10814 =

>   plugins/git/gitmessagehighlighter.cpp b7239f4274bc2d771f7d9434703fc1d01=
73f7e92 =

>   plugins/git/gitplugin.h eae2bb37582dd3c60af224c14bf4be8d9195bc32 =

>   plugins/git/gitplugin.cpp fe88f271acb9ccdd6e9e617e1c98ab6c063cc1b3 =

>   plugins/git/stashmanagerdialog.cpp bf0f6a45c54bc10ab28838e8a1712ec8fbf1=
a34a =

>   plugins/grepview/greputil.h 446286e887cc1b78105f834783cd1c75ab932062 =

>   plugins/grepview/greputil.cpp 0447a2655f965ef2f44eb35075a179bd22e4460a =

>   plugins/patchreview/patchreview.ui 06e80bb4a9b207586ef1d6d7d3ec68073849=
8210 =

>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 750dded23ee10c3=
cb0d6e6946967e0d9dcc0f1da =

>   plugins/quickopen/quickopenplugin.cpp e467ad06bf29a9f4a6ec8b9cb71b06cbd=
3cdf2f5 =

>   plugins/snippet/editrepository.ui 2432bb47e4260007c8eef0f7152cb94ca50fb=
d40 =

>   plugins/snippet/snippetcompletionitem.cpp 732900b2f5b76e38dbc715b64b29c=
207df8a5210 =

>   plugins/subversion/ui/ssltrustdialog.ui ffc7e7922683c868670738f1f4611be=
075a59ab0 =

>   shell/projectinfopage.ui d7b1cb83bd98f5cc7476105811438ef8863bacdb =

>   shell/projectsourcepage.ui b87508f6ba625095d4d854d08b8abe37cbc0c1e5 =

>   shell/settings/uiconfig.ui 3fb219bc2138ce754f5c1d16e09f88e4ee31d37a =

>   sublime/tests/viewactivationtest.cpp df6d92b267e63c4c1c25e182bd60df927c=
4e6437 =

>   util/ssh_client/main.h 446a1a924c7fa4373c05f213d83cd31f1c82c093 =

>   vcs/dvcs/ui/branchmanager.cpp be6e82564f3ec0fe751e2d74e4c5ccfa54a2571d =

>   vcs/dvcs/ui/cvsgenericoutputview.ui 58a273e4d0967dda949b49be964ba579aa8=
9c5f5 =

>   vcs/interfaces/ibasicversioncontrol.h 8b47390780889f9d02d652d28932eb540=
3e2592b =

>   vcs/interfaces/ibasicversioncontrol.cpp fe6003584618d41f56acce389109eda=
6030ca689 =

>   vcs/widgets/vcsdiffpatchsources.h f4be887dfa58c99a648c52320a390daf0d403=
c0b =

>   vcs/widgets/vcsdiffpatchsources.cpp 9a90af2a1d9e063a417ec54aa2e67e71a34=
5dee4 =

>   vcs/widgets/vcseventwidget.ui 09bd430de7f5a21f28bd099deb954d6f665f0db1 =

>   debugger/breakpoint/breakpointdetails.h b937a9cd4cb84f8e3e20d791490a1c3=
bf746ef1f =

>   debugger/breakpoint/breakpointdetails.cpp a3a0fc50fd0cee27c8c8fbb153ead=
c3287cdd91f =

>   documentation/documentationview.h e577b2fe7c65868b926f25d33456ed52ba87b=
1f9 =

> =

> Diff: http://git.reviewboard.kde.org/r/104823/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Ghislain Mary
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104823/">http://git.reviewboard.kde.org/r/104823/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you verify wether \
these changes have any side-effects? in general its often ok to just use the \
k-classes, butmaybe in some of the cases the use of the Qt version was intentional. A \
look at the history may also indicate such decisions.</pre>  <br />

<p>- Andreas</p>

<br />
<p>On May 2nd, 2012, 3:28 p.m., Ghislain Mary wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Ghislain Mary.</div>

<p style="color: grey;"><i>Updated May 2, 2012, 3:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed a great part of the Qt classes krazy checks (replace Qt classes \
that should not be used by there KDE counterparts).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>documentation/documentationview.cpp <span style="color: \
grey">(53e05a88cc3b0f6b4a06864c82f85540fd7f9243)</span></li>

 <li>plugins/appwizard/projectselectionpage.ui <span style="color: \
grey">(7a33fdd2c68831776ea5dc8d7259afa831854a41)</span></li>

 <li>plugins/cvs/cvsgenericoutputview.ui <span style="color: \
grey">(58a273e4d0967dda949b49be964ba579aa89c5f5)</span></li>

 <li>plugins/dashboard/plasmoids/projectfileplasmoid/config.ui <span style="color: \
grey">(d7be64440e21f3e988029d40d299560a50e1f0f9)</span></li>

 <li>plugins/execute/projecttargetscombobox.h <span style="color: \
grey">(154226844e5a3e7f5c40a09bf86ba47d99f5237f)</span></li>

 <li>plugins/execute/projecttargetscombobox.cpp <span style="color: \
grey">(1096093c07408392daef38d6f4e3b2884babc8fd)</span></li>

 <li>plugins/externalscript/editexternalscript.ui <span style="color: \
grey">(cd747e649148a941a42f81d5d5553c6a0bfb7957)</span></li>

 <li>plugins/git/gitmessagehighlighter.h <span style="color: \
grey">(5d65e7c9401315b16e8f90c0ce2d49e4f4910814)</span></li>

 <li>plugins/git/gitmessagehighlighter.cpp <span style="color: \
grey">(b7239f4274bc2d771f7d9434703fc1d0173f7e92)</span></li>

 <li>plugins/git/gitplugin.h <span style="color: \
grey">(eae2bb37582dd3c60af224c14bf4be8d9195bc32)</span></li>

 <li>plugins/git/gitplugin.cpp <span style="color: \
grey">(fe88f271acb9ccdd6e9e617e1c98ab6c063cc1b3)</span></li>

 <li>plugins/git/stashmanagerdialog.cpp <span style="color: \
grey">(bf0f6a45c54bc10ab28838e8a1712ec8fbf1a34a)</span></li>

 <li>plugins/grepview/greputil.h <span style="color: \
grey">(446286e887cc1b78105f834783cd1c75ab932062)</span></li>

 <li>plugins/grepview/greputil.cpp <span style="color: \
grey">(0447a2655f965ef2f44eb35075a179bd22e4460a)</span></li>

 <li>plugins/patchreview/patchreview.ui <span style="color: \
grey">(06e80bb4a9b207586ef1d6d7d3ec680738498210)</span></li>

 <li>plugins/projectmanagerview/projectmanagerviewplugin.cpp <span style="color: \
grey">(750dded23ee10c3cb0d6e6946967e0d9dcc0f1da)</span></li>

 <li>plugins/quickopen/quickopenplugin.cpp <span style="color: \
grey">(e467ad06bf29a9f4a6ec8b9cb71b06cbd3cdf2f5)</span></li>

 <li>plugins/snippet/editrepository.ui <span style="color: \
grey">(2432bb47e4260007c8eef0f7152cb94ca50fbd40)</span></li>

 <li>plugins/snippet/snippetcompletionitem.cpp <span style="color: \
grey">(732900b2f5b76e38dbc715b64b29c207df8a5210)</span></li>

 <li>plugins/subversion/ui/ssltrustdialog.ui <span style="color: \
grey">(ffc7e7922683c868670738f1f4611be075a59ab0)</span></li>

 <li>shell/projectinfopage.ui <span style="color: \
grey">(d7b1cb83bd98f5cc7476105811438ef8863bacdb)</span></li>

 <li>shell/projectsourcepage.ui <span style="color: \
grey">(b87508f6ba625095d4d854d08b8abe37cbc0c1e5)</span></li>

 <li>shell/settings/uiconfig.ui <span style="color: \
grey">(3fb219bc2138ce754f5c1d16e09f88e4ee31d37a)</span></li>

 <li>sublime/tests/viewactivationtest.cpp <span style="color: \
grey">(df6d92b267e63c4c1c25e182bd60df927c4e6437)</span></li>

 <li>util/ssh_client/main.h <span style="color: \
grey">(446a1a924c7fa4373c05f213d83cd31f1c82c093)</span></li>

 <li>vcs/dvcs/ui/branchmanager.cpp <span style="color: \
grey">(be6e82564f3ec0fe751e2d74e4c5ccfa54a2571d)</span></li>

 <li>vcs/dvcs/ui/cvsgenericoutputview.ui <span style="color: \
grey">(58a273e4d0967dda949b49be964ba579aa89c5f5)</span></li>

 <li>vcs/interfaces/ibasicversioncontrol.h <span style="color: \
grey">(8b47390780889f9d02d652d28932eb5403e2592b)</span></li>

 <li>vcs/interfaces/ibasicversioncontrol.cpp <span style="color: \
grey">(fe6003584618d41f56acce389109eda6030ca689)</span></li>

 <li>vcs/widgets/vcsdiffpatchsources.h <span style="color: \
grey">(f4be887dfa58c99a648c52320a390daf0d403c0b)</span></li>

 <li>vcs/widgets/vcsdiffpatchsources.cpp <span style="color: \
grey">(9a90af2a1d9e063a417ec54aa2e67e71a345dee4)</span></li>

 <li>vcs/widgets/vcseventwidget.ui <span style="color: \
grey">(09bd430de7f5a21f28bd099deb954d6f665f0db1)</span></li>

 <li>debugger/breakpoint/breakpointdetails.h <span style="color: \
grey">(b937a9cd4cb84f8e3e20d791490a1c3bf746ef1f)</span></li>

 <li>debugger/breakpoint/breakpointdetails.cpp <span style="color: \
grey">(a3a0fc50fd0cee27c8c8fbb153eadc3287cdd91f)</span></li>

 <li>documentation/documentationview.h <span style="color: \
grey">(e577b2fe7c65868b926f25d33456ed52ba87b1f9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104823/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 