[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Memory viewer fixes.
From: "Niko Sams" <niko.sams () gmail ! com>
Date: 2012-04-22 11:59:15
Message-ID: 20120422115915.28733.13834 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104574/#review12786
-----------------------------------------------------------
Ship it!
I've never looked into that part of the debugger, so I'd say the review sho=
uld be done by Friedrich best. So Ship It after fixing the issues he pointe=
d out.
And go ahead with more patches that actually re-activate this widget.
- Niko Sams
On April 13, 2012, 12:19 a.m., Ben Wagner wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104574/
> -----------------------------------------------------------
> =
> (Updated April 13, 2012, 12:19 a.m.)
> =
> =
> Review request for KDevelop.
> =
> =
> Description
> -------
> =
> This is a somewhat odd patch, since it changes what is currently dead cod=
e. However, uncommenting the relevant portions of debuggerplugin.* and CMak=
eLists in debuggers/gdb allows it to be used. This change makes the memory =
viewer at least work and not crash, which is an improvement over the existi=
ng state. This code needs more work before being re-enabled, as does the co=
de which calls it (it is rather strange the way it's UI is set up). However=
, this is a good checkpoint.
> =
> =
> Diffs
> -----
> =
> debuggers/gdb/memviewdlg.h 1629cd0 =
> debuggers/gdb/memviewdlg.cpp 0500a21 =
> =
> Diff: http://git.reviewboard.kde.org/r/104574/diff/
> =
> =
> Testing
> -------
> =
> Got it working. Used it. When Okteta is installed it works and I haven't =
gotten it to crash again yet.
> =
> =
> Thanks,
> =
> Ben Wagner
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104574/">http://git.reviewboard.kde.org/r/104574/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've never looked \
into that part of the debugger, so I'd say the review should be done by Friedrich \
best. So Ship It after fixing the issues he pointed out.
And go ahead with more patches that actually re-activate this widget.</pre>
<br />
<p>- Niko</p>
<br />
<p>On April 13th, 2012, 12:19 a.m., Ben Wagner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ben Wagner.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 12:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a somewhat odd patch, since it changes what is currently dead \
code. However, uncommenting the relevant portions of debuggerplugin.* and CMakeLists \
in debuggers/gdb allows it to be used. This change makes the memory viewer at least \
work and not crash, which is an improvement over the existing state. This code needs \
more work before being re-enabled, as does the code which calls it (it is rather \
strange the way it's UI is set up). However, this is a good checkpoint.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Got it working. Used it. When Okteta is installed it works and I \
haven't gotten it to crash again yet.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/memviewdlg.h <span style="color: grey">(1629cd0)</span></li>
<li>debuggers/gdb/memviewdlg.cpp <span style="color: grey">(0500a21)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104574/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic