'Review Request: Actually use ExecuteBrowserPlugin in XDebugJob'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Review Request: Actually use ExecuteBrowserPlugin in XDebugJob
From:       "Dominik Schmidt" <ich () dominik-schmidt ! de>
Date:       2012-04-13 23:29:07
Message-ID: 20120413232907.25078.42400 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104595/
-----------------------------------------------------------

Review request for KDevelop and Quanta.

Description
-------

Currently the XDebugJob always uses QDesktopServices::openUrl() to open the=
 debug page in the browser, this patch makes use of the ExecuteBrowserPlugi=
n instance that is already present in XDebug job so the configured browser =
is launched.

Also it makes BrowserAppJob launch the external browser KProc with .startDe=
tached() instead of .execute() to prevent freezing of the KDevelop GUI.

Arguments are currently ignored still, a patch for that is following

Feel free to nitpick, I haven't done any KDE coding in a while and would li=
ke to hear any suggestion for improvements :-)

Diffs
-----

  debuggers/xdebug/debugjob.h 9925733 =

  debuggers/xdebug/debugjob.cpp 0f04914 =

  plugins/executebrowser/browserappjob.h 37ff700 =

  plugins/executebrowser/browserappjob.cpp a211205 =

  plugins/executebrowser/executebrowserplugin.h 7c78733 =

  plugins/executebrowser/executebrowserplugin.cpp 921142f =

  plugins/executebrowser/iexecutebrowserplugin.h f786622 =

Diff: http://git.reviewboard.kde.org/r/104595/diff/

Testing
-------

It works ... ;-)

Thanks,

Dominik Schmidt

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104595/">http://git.reviewboard.kde.org/r/104595/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop and Quanta.</div>
<div>By Dominik Schmidt.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the XDebugJob always uses QDesktopServices::openUrl() to open \
the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin \
instance that is already present in XDebug job so the configured browser is launched.

Also it makes BrowserAppJob launch the external browser KProc with .startDetached() \
instead of .execute() to prevent freezing of the KDevelop GUI.

Arguments are currently ignored still, a patch for that is following

Feel free to nitpick, I haven&#39;t done any KDE coding in a while and would like to \
hear any suggestion for improvements :-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works ... ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>debuggers/xdebug/debugjob.h <span style="color: grey">(9925733)</span></li>

 <li>debuggers/xdebug/debugjob.cpp <span style="color: grey">(0f04914)</span></li>

 <li>plugins/executebrowser/browserappjob.h <span style="color: \
grey">(37ff700)</span></li>

 <li>plugins/executebrowser/browserappjob.cpp <span style="color: \
grey">(a211205)</span></li>

 <li>plugins/executebrowser/executebrowserplugin.h <span style="color: \
grey">(7c78733)</span></li>

 <li>plugins/executebrowser/executebrowserplugin.cpp <span style="color: \
grey">(921142f)</span></li>

 <li>plugins/executebrowser/iexecutebrowserplugin.h <span style="color: \
grey">(f786622)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104595/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 