[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Add GHNS support for Qt Compressed Help
From: "Benjamin Port" <port.benjamin () gmail ! com>
Date: 2012-02-13 14:34:30
Message-ID: 20120213143430.23384.42420 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 18, 2011, 6:14 p.m., Milian Wolff wrote:
> > awesome work, as usual guys. The only question is: Where do we host tha=
t synchroton?
> > =
> > And btw: it shows a bug in the documentation plugin: when you install a=
new .qch file, it will be added to the combo box in the documentation view=
and it is selected there. but the documentation tool view will still show =
the contents of the last selected .qch file (for me it was plain Qt). Pleas=
e fix that as well.
> =
> Aleix Pol Gonzalez wrote:
> It will use the KDE synchrotron. We already discussed that with aaron.
> =
> Aleix Pol Gonzalez wrote:
> ah and ship-it+1 :)
> =
> Benjamin Port wrote:
> Ok, I'll merge it when I have KDE synchrotron url
> =
> Aleix Pol Gonzalez wrote:
> Hey Benjamin. Was this merged? Will you or there are missing issues?
Not yet merged.
I look for that tonight or tomorrow. Just need to change synchrotron URL.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100422/#review983
-----------------------------------------------------------
On Jan. 18, 2011, 1:52 p.m., Benjamin Port wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100422/
> -----------------------------------------------------------
> =
> (Updated Jan. 18, 2011, 1:52 p.m.)
> =
> =
> Review request for KDevelop.
> =
> =
> Description
> -------
> =
> Allow user to get documentation with GHNS.
> =
> However the .knsrc file change before merging with master (to use the fin=
al synchrotron url)
> =
> =
> Diffs
> -----
> =
> documentation/qthelp/CMakeLists.txt 43603ec =
> documentation/qthelp/kdevelop-qthelp.knsrc PRE-CREATION =
> documentation/qthelp/qthelp_config_shared.h 157288d =
> documentation/qthelp/qthelp_config_shared.cpp 562916f =
> documentation/qthelp/qthelpconfig.h e02a26d =
> documentation/qthelp/qthelpconfig.cpp 2832caa =
> documentation/qthelp/qthelpconfig.ui 7269c80 =
> documentation/qthelp/qthelpplugin.cpp 320377e =
> documentation/qthelp/tests/testqthelpplugin.cpp 9d058a0 =
> =
> Diff: http://git.reviewboard.kde.org/r/100422/diff/
> =
> =
> Testing
> -------
> =
> Unit test still works =
> =
> =
> Thanks,
> =
> Benjamin Port
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100422/">http://git.reviewboard.kde.org/r/100422/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 18th, 2011, 6:14 p.m., <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">awesome work, as usual guys. The only question is: Where do we host that \
synchroton?
And btw: it shows a bug in the documentation plugin: when you install a new .qch \
file, it will be added to the combo box in the documentation view and it is selected \
there. but the documentation tool view will still show the contents of the last \
selected .qch file (for me it was plain Qt). Please fix that as well.</pre> \
</blockquote>
<p>On January 18th, 2011, 8:30 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It will use the KDE \
synchrotron. We already discussed that with aaron.</pre> </blockquote>
<p>On January 18th, 2011, 8:31 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah and ship-it+1 \
:)</pre> </blockquote>
<p>On January 18th, 2011, 10:57 p.m., <b>Benjamin Port</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I'll merge it \
when I have KDE synchrotron url</pre> </blockquote>
<p>On February 12th, 2012, 5:05 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey Benjamin. Was this \
merged? Will you or there are missing issues?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not yet merged. I look \
for that tonight or tomorrow. Just need to change synchrotron URL.</pre> <br />
<p>- Benjamin</p>
<br />
<p>On January 18th, 2011, 1:52 p.m., Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2011, 1:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow user to get documentation with GHNS.
However the .knsrc file change before merging with master (to use the final \
synchrotron url)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit test still works </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>documentation/qthelp/CMakeLists.txt <span style="color: \
grey">(43603ec)</span></li>
<li>documentation/qthelp/kdevelop-qthelp.knsrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>documentation/qthelp/qthelp_config_shared.h <span style="color: \
grey">(157288d)</span></li>
<li>documentation/qthelp/qthelp_config_shared.cpp <span style="color: \
grey">(562916f)</span></li>
<li>documentation/qthelp/qthelpconfig.h <span style="color: \
grey">(e02a26d)</span></li>
<li>documentation/qthelp/qthelpconfig.cpp <span style="color: \
grey">(2832caa)</span></li>
<li>documentation/qthelp/qthelpconfig.ui <span style="color: \
grey">(7269c80)</span></li>
<li>documentation/qthelp/qthelpplugin.cpp <span style="color: \
grey">(320377e)</span></li>
<li>documentation/qthelp/tests/testqthelpplugin.cpp <span style="color: \
grey">(9d058a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100422/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic