[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Add more php example code to show the formatters
From: "Florian Zumkeller-Quast" <branleb () googlemail ! com>
Date: 2011-12-23 22:04:21
Message-ID: 20111223220421.16938.37554 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2011, 8:17 p.m., Milian Wolff wrote:
> > Uhm sorry, but when I download the diff it is still not in the "format-=
patch" format. Just look at the downloaded file, it directly starts with th=
e patch and gives no information about you, nor any commit message or such.
> > =
> > please try again
Still seems not to work. Don't know why.
So i'll provide the files here:
This is the "parent" patch (see review 103386) which is required when using=
git-am http://branleb.de/kdevelop-patches/0001-Applied-KDevPlatform-change=
s-for-ISourceFormatter-to.patch
The real patch is located here: http://branleb.de/kdevelop-patches/0002-Add=
ed-more-example-php-code-the-show-the-impact-of-m.patch
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103388/#review9220
-----------------------------------------------------------
On Dec. 23, 2011, 9:55 p.m., Florian Zumkeller-Quast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103388/
> -----------------------------------------------------------
> =
> (Updated Dec. 23, 2011, 9:55 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Added some more php example code to show the impact of the formatter if a=
pplied
> =
> =
> Diffs
> -----
> =
> plugins/phpformatter/formatterplugin.cpp f1ca6fd =
> =
> Diff: http://git.reviewboard.kde.org/r/103388/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Florian Zumkeller-Quast
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103388/">http://git.reviewboard.kde.org/r/103388/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2011, 8:17 p.m., <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Uhm sorry, but when I download the diff it is still not in the \
"format-patch" format. Just look at the downloaded file, it directly starts \
with the patch and gives no information about you, nor any commit message or such.
please try again</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still seems not to work. \
Don't know why. So i'll provide the files here:
This is the "parent" patch (see review 103386) which is required when using \
git-am http://branleb.de/kdevelop-patches/0001-Applied-KDevPlatform-changes-for-ISourceFormatter-to.patch
The real patch is located here: \
http://branleb.de/kdevelop-patches/0002-Added-more-example-php-code-the-show-the-impact-of-m.patch</pre>
<br />
<p>- Florian</p>
<br />
<p>On December 23rd, 2011, 9:55 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2011, 9:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added some more php example code to show the impact of the formatter if \
applied</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: \
grey">(f1ca6fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103388/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic