[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: tab management in kdev master
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2011-07-19 11:28:04
Message-ID: CACcA1RpXUTqJDonh-Js=v2LF066mMsA4X1yJxsqTzON=kEbi5A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Jul 19, 2011 at 6:57 AM, Steffen Ohrendorf
<mr.syron@googlemail.com>wrote:

> I had a look at it, commit 3ca6c8de3bcfd61d23f279e7364a3d0ff9a32c41 seems
> to
> be the problem, because if(!m_indexSplitters.contains(index)) has been
> replaced by if(!m_indexSplitters[index]), but the documentation of QMap
> states
> cleary that operator[] returns a default constructed object when there's no
> key found.
> (only my 2 cents...)
> -- Syron
>
> --
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

Well, the default constructor will return false (null QPointer), no?

[Attachment #5 (text/html)]

<div class="gmail_quote">On Tue, Jul 19, 2011 at 6:57 AM, Steffen Ohrendorf <span \
dir="ltr">&lt;<a href="mailto:mr.syron@googlemail.com">mr.syron@googlemail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">

I had a look at it, commit 3ca6c8de3bcfd61d23f279e7364a3d0ff9a32c41 seems to<br>
be the problem, because if(!m_indexSplitters.contains(index)) has been<br>
replaced by if(!m_indexSplitters[index]), but the documentation of QMap states<br>
cleary that operator[] returns a default constructed object when there&#39;s no<br>
key found.<br>
(only my 2 cents...)<br>
-- Syron<br>
<font color="#888888"><br>
--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
 </font></blockquote></div><br><div><meta http-equiv="content-type" \
content="text/html; charset=utf-8">Well, the default constructor will return false \
(null QPointer), no?</div>



-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]