[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: RValue reference support
From:       David Nolden <zwabel () googlemail ! com>
Date:       2011-06-03 13:18:07
Message-ID: BANLkTinu=NaFzGrVXkNv6CUWkFFen3G2+g () mail ! gmail ! com
[Download RAW message or body]

2011/6/2 Milian Wolff <mail@milianw.de>:
> PS: anything wrong with my other commits, have you had time to review them
> (partially) ?

Not thorougly, but it looked ok.

Regarding the ReferenceType extension: Actually, for consistency and
memory-saving, it would be better if you would add a modifier
"AbstractType::IsRValueModifier", equal to
"AbstractType::ConstModifier". This would reduce the size of
ReferenceTypeData by 4 bytes, and it would generally allow flagging
any types as RValues, which _might_ become useful in future. As for
the uglyness of using the modifiers, I think we should add some helper
overloads like "bool AbstractType::isRValue() const { return
d_func()->m_modifiers & IsRValueModifier; }" and "setIsRValue" (the
same for ConstModifier).

Greetings, David

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]