'Re: Review Request: Fix crash when KTextEdit::Factory is not found'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Fix crash when KTextEdit::Factory is not found
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2011-04-04 9:04:31
Message-ID: 20110404090431.30434.74264 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100949/#review2379
-----------------------------------------------------------

Ship it!

looks good now, I prefferr it that way. but I wonder - return code -1? shou=
ldn't it be an int between 1 and 255?

- Milian

On April 4, 2011, 7:35 a.m., Robert Mathias Marmorstein wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100949/
> -----------------------------------------------------------
> =

> (Updated April 4, 2011, 7:35 a.m.)
> =

> =

> Review request for KDevelop and Quanta.
> =

> =

> Summary
> -------
> =

> This patch fixes a crash which occurs when closing kdevelop or quanta aft=
er the "KTextEditor::Factory not found" error box is displayed.  The proble=
m is a simple logic error caused by the fact that QApplicationCore::exit() =
does not immediately abort an application.  Instead, it causes event proces=
sing to cease, which indirectly terminates the application AFTER the functi=
on has returned to the main event loop.
> =

> =

> Diffs
> -----
> =

>   shell/partcontroller.cpp 5a81de0 =

> =

> Diff: http://git.reviewboard.kde.org/r/100949/diff
> =

> =

> Testing
> -------
> =

> Recompiled, ran quanta and kdevelop.  Error message dialog still comes up=
 (as it should), but the program closes without crashing now.
> =

> =

> Thanks,
> =

> Robert Mathias
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100949/">http://git.reviewboard.kde.org/r/100949/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good now, I \
prefferr it that way. but I wonder - return code -1? shouldn&#39;t it be an int \
between 1 and 255?</pre>  <br />

<p>- Milian</p>

<br />
<p>On April 4th, 2011, 7:35 a.m., Robert Mathias Marmorstein wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop and Quanta.</div>
<div>By Robert Mathias Marmorstein.</div>

<p style="color: grey;"><i>Updated April 4, 2011, 7:35 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a crash which occurs when closing kdevelop or quanta \
after the &quot;KTextEditor::Factory not found&quot; error box is displayed.  The \
problem is a simple logic error caused by the fact that QApplicationCore::exit() does \
not immediately abort an application.  Instead, it causes event processing to cease, \
which indirectly terminates the application AFTER the function has returned to the \
main event loop.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Recompiled, ran quanta and kdevelop.  Error message dialog still comes \
up (as it should), but the program closes without crashing now.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/partcontroller.cpp <span style="color: grey">(5a81de0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100949/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 