[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: [PATCH] fix build errors in kdevplatform-1.2.0
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2011-03-28 10:00:39
Message-ID: AANLkTi=cD+ygeFjT+MUH+JhqAoEYe=OPkYPgbr_2keA4 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Mar 27, 2011 at 10:14 PM, Erik <esigra@gmail.com> wrote:

> This patch fixes the following errors in kdevplatform 1.2.0 so that it can
> be built:
> * Define metatypes in header files and include them instead of having
> multiple Q_DECLARE_METATYPE(TYPE) for the same TYPE (see
> http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).
> * Explicit static casts where needed according to the compiler.
> * Define urlToData in one place only (a separate new header file).
> * Rename one of the functions appendActions to appendContextMenuActions to
> make the signature unique.
> * Add include guard to greputil.h
> * Rename one of the structs Visitor to selfAnalysisVisitor to make the
> identifier unique.
> * Use a unique include guard in appendlist_static.h (not the same as in
> appendlist.h)
> * Undefine the macro "mix" after use to not pollute the namespace.
>
>
> --
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
Under what circumstances is all this necessary?

Why do you static_cast<Qt::ItemFlags> to create the enum? It has never been
needed...

All in all, I'd prefer to be able to discuss every change over reviewboard,
As suggested by Andrey.

Aleix

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sun, Mar 27, 2011 at 10:14 PM, Erik <span \
dir="ltr">&lt;<a href="mailto:esigra@gmail.com">esigra@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">

This patch fixes the following errors in kdevplatform 1.2.0 so that it can be \
                built:<br>
* Define metatypes in header files and include them instead of having multiple \
Q_DECLARE_METATYPE(TYPE) for the same TYPE (see <a \
href="http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html" \
target="_blank">http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html</a>).<br>



* Explicit static casts where needed according to the compiler.<br>
* Define urlToData in one place only (a separate new header file).<br>
* Rename one of the functions appendActions to appendContextMenuActions to make the \
                signature unique.<br>
* Add include guard to greputil.h<br>
* Rename one of the structs Visitor to selfAnalysisVisitor to make the identifier \
                unique.<br>
* Use a unique include guard in appendlist_static.h (not the same as in \
                appendlist.h)<br>
* Undefine the macro &quot;mix&quot; after use to not pollute the namespace.<br>
<br>
<br>--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
 <br></blockquote></div><div><br></div><div>Under what circumstances is all this \
necessary?</div><br><div><meta http-equiv="content-type" content="text/html; \
charset=utf-8">Why do you  <span class="Apple-style-span" style="font-family: \
monospace; white-space: pre-wrap; font-size: medium; \
">static_cast&lt;Qt::ItemFlags&gt;</span>  to create the enum? It has never been \
needed...</div>

<div><br></div><div>All in all, I&#39;d prefer to be able to discuss every change \
over reviewboard, As suggested by Andrey.</div><div><br></div><div>Aleix</div>



-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]