'Re: Review Request: Respect parent constructor aruments when'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Respect parent constructor aruments when
From:       "Dmitry Risenberg" <dmitry.risenberg () gmail ! com>
Date:       2011-03-27 20:20:34
Message-ID: 20110327202034.3585.49152 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100924/#review2197
-----------------------------------------------------------

OK, I'll push this if there's no objections.

- Dmitry

On March 22, 2011, 10:39 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100924/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 10:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Try to match parent class constructor arguments as good as possible, first by type \
> and then by name. If parent class has multiple constructors, try to find the one \
> that matches the best to this class' constructor arguments. 
> 
> This addresses bug 255038.
> http://bugs.kde.org/show_bug.cgi?id=255038
> 
> 
> Diffs
> -----
> 
> languages/cpp/codecompletion/context.cpp 651779f 
> languages/cpp/codecompletion/implementationhelperitem.cpp fd29e4a 
> languages/cpp/tests/test_cppcodecompletion.h dcc975c 
> languages/cpp/tests/test_cppcodecompletion.cpp ab61271 
> 
> Diff: http://git.reviewboard.kde.org/r/100924/diff
> 
> 
> Testing
> -------
> 
> Unit tests + example from bug report.
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100924/">http://git.reviewboard.kde.org/r/100924/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I&#39;ll push this \
if there&#39;s no objections.</pre>  <br />

<p>- Dmitry</p>

<br />
<p>On March 22nd, 2011, 10:39 p.m., Dmitry Risenberg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>

<p style="color: grey;"><i>Updated March 22, 2011, 10:39 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Try to match parent class constructor arguments as good as possible, \
first by type and then by name. If parent class has multiple constructors, try to \
find the one that matches the best to this class&#39; constructor arguments.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests + example from bug report.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=255038">255038</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>languages/cpp/codecompletion/context.cpp <span style="color: \
grey">(651779f)</span></li>

 <li>languages/cpp/codecompletion/implementationhelperitem.cpp <span style="color: \
grey">(fd29e4a)</span></li>

 <li>languages/cpp/tests/test_cppcodecompletion.h <span style="color: \
grey">(dcc975c)</span></li>

 <li>languages/cpp/tests/test_cppcodecompletion.cpp <span style="color: \
grey">(ab61271)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100924/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 