[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Review Request: connect return value tested instead of errno
From: "Lambert CLARA" <lambert.clara () yahoo ! fr>
Date: 2011-03-27 16:44:30
Message-ID: 20110327164430.27696.4148 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100959/
-----------------------------------------------------------
Review request for KDevelop.
Summary
-------
The connect() system call returns 0 if successful, and if not returns -1 an=
d sets errno.
The return value of connect was tested instead of errno, this patch fixes t=
hat.
Diffs
-----
util/dbus_socket_transformer/main.cpp 17019ce =
Diff: http://git.reviewboard.kde.org/r/100959/diff
Testing
-------
Compilation only.
Thanks,
Lambert
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100959/">http://git.reviewboard.kde.org/r/100959/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Lambert CLARA.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The connect() system call returns 0 if successful, and if not returns -1 \
and sets errno. The return value of connect was tested instead of errno, this patch \
fixes that.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compilation only.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>util/dbus_socket_transformer/main.cpp <span style="color: \
grey">(17019ce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100959/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic