[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Run GDB inside shell bug fix
From: "Milian Wolff" <mail () milianw ! de>
Date: 2011-02-05 17:53:44
Message-ID: 20110205175344.5978.92067 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100509/#review1242
-----------------------------------------------------------
Ship it!
looks good, can you send it to me as outputted by "git format-patch" please?
debuggers/gdb/gdb.cpp
<http://git.reviewboard.kde.org/r/100509/#comment1041>
think about using KSell::splitArgs here just to make sure
http://api.kde.org/4.2-api/kdelibs-apidocs/kdecore/html/namespaceKShell.html#8d7c7dda510b29a6dfd7834a93f0a369
debuggers/gdb/gdb.cpp
<http://git.reviewboard.kde.org/r/100509/#comment1040>
merge that with the debug output above imo:
kDebug(9012) << "have shell:" << shellUrl.url() << shell;
or similar. also "\n" is not required when using kDebug (the old code is wrong \
there).
- Milian
On Feb. 1, 2011, 2:48 p.m., Pauli Sundberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100509/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2011, 2:48 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Kdevelop 4.2 branch debug launcher debugger shell was not working. It gave error:
> "Could not locate the debugging shell \
> 'file:///home/sundberg/eigenor/systemio/trunk/debug/libtool%20--mode=execute'."
> when inputted to dialog was:
> /home/sundberg/eigenor/systemio/trunk/debug/libtool --mode=execute
>
> This patch does not solve libtool issue, though the shell seems to be working.
>
> From output:
>
> kdevelop(2680)/kdevelop (gdb debugger) GDBDebugger::GDB::start: Starting shell by: \
> "'/home/sundberg/eigenor/systemio/trunk/debug/libtool --mode=execute' gdb \
> --interpreter=mi2 -quiet"
> Where do those extra ' come around the shell? Though the shell is started properly.
>
>
> Diffs
> -----
>
> debuggers/gdb/gdb.cpp 02e23fa
>
> Diff: http://git.reviewboard.kde.org/r/100509/diff
>
>
> Testing
> -------
>
> Checked that debugger started properly.
>
>
> Thanks,
>
> Pauli
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100509/">http://git.reviewboard.kde.org/r/100509/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, can you send \
it to me as outputted by "git format-patch" please?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100509/diff/1/?file=8066#file8066line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">debuggers/gdb/gdb.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
GDB::start(KConfigGroup& config)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">82</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">shell_without_args</span> <span \
class="o">=</span> <span class="n">shell</span><span class="p">.</span><span \
class="n">split</span><span class="p">(</span><span class="n">QChar</span><span \
class="p">(</span><span class="sc">' '</span><span class="p">)).</span><span \
class="n">first</span><span class="p">();</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">83</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">shell_without_args</span> <span \
class="o">=</span> <span class="n">shell</span><span class="p">.</span><span \
class="n">split</span><span class="p">(</span><span class="n">QChar</span><span \
class="p">(</span><span class="sc">' '</span><span class="p">)).</span><span \
class="n">first</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">think about \
using KSell::splitArgs here just to make sure
http://api.kde.org/4.2-api/kdelibs-apidocs/kdecore/html/namespaceKShell.html#8d7c7dda510b29a6dfd7834a93f0a369</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100509/diff/1/?file=8066#file8066line85" \
style="color: black; font-weight: bold; text-decoration: \
underline;">debuggers/gdb/gdb.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
GDB::start(KConfigGroup& config)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">85</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">(</span><span class="mi">9012</span><span \
class="p">)</span> <span class="o"><<</span> <span class="s">"have shell \
defined shell: "</span> <span class="o"><<</span> <span \
class="n">shell</span> <span class="o"><<</span> <span \
class="s">"</span><span class="se">\n</span><span class="s">"</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">merge that \
with the debug output above imo:
kDebug(9012) << "have shell:" << shellUrl.url() << shell;
or similar. also "\n" is not required when using kDebug (the old code is \
wrong there).</pre> </div>
<br />
<p>- Milian</p>
<br />
<p>On February 1st, 2011, 2:48 p.m., Pauli Sundberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Pauli Sundberg.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2011, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kdevelop 4.2 branch debug launcher debugger shell was not working. It \
gave error: "Could not locate the debugging shell \
'file:///home/sundberg/eigenor/systemio/trunk/debug/libtool%20--mode=execute'."
when inputted to dialog was:
/home/sundberg/eigenor/systemio/trunk/debug/libtool --mode=execute
This patch does not solve libtool issue, though the shell seems to be working.
> From output:
kdevelop(2680)/kdevelop (gdb debugger) GDBDebugger::GDB::start: Starting shell by: \
"'/home/sundberg/eigenor/systemio/trunk/debug/libtool --mode=execute' \
gdb --interpreter=mi2 -quiet"
Where do those extra ' come around the shell? Though the shell is started \
properly.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked that debugger started properly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/gdb.cpp <span style="color: grey">(02e23fa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100509/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic