[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Check for possible unloading of version control
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-12-24 14:11:16
Message-ID: 201012241511.18688.mail () milianw ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 21 December 2010 14:06:39 Aleix Pol Gonzalez wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100225/#review592
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Looks good to me.
> Can we remove the hasError method now?

I've investigated it today and no, it's not possible. 

Or well, it would be possible if we only return QWeakPointers everywhere from 
the PluginController. 

pluginManager->allPluginsForExtension( "org.kdevelop.IBasicVersionControl" )

That call in project.cpp:386 can lead to crashes if we unload the git plugin 
via some Qt::QueuedConnection, even if I temporarily use a list of 
QWeakPointers in allPluginsForExtension and convert it afterwards.

Anyhow, I don't find that API too bad, it's quite easy to use and works well. 
So should we live with it?

Bye
-- 
Milian Wolff
mail@milianw.de
http://milianw.de

["signature.asc" (application/pgp-signature)]

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]