'Review Request: ptrtomembertype implementation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Review Request: ptrtomembertype implementation
From:       "Floris Ruijter" <flo.ruijt () hotmail ! com>
Date:       2010-12-23 23:05:09
Message-ID: 20101223230509.24820.57844 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100241/
-----------------------------------------------------------

Review request for KDevelop.

Summary
-------

implementing the PtrToMemberType, type which represents pointer-to-member t=
ypes ;) like int foo::* bar;

Diffs
-----

  language/CMakeLists.txt 67985db =

  language/duchain/types/alltypes.h e233985 =

  language/duchain/types/pointertype.h deb40ed =

  language/duchain/types/ptrtomembertype.h PRE-CREATION =

  language/duchain/types/ptrtomembertype.cpp PRE-CREATION =

  language/duchain/types/typesystem.cpp 941e541 =

  language/duchain/types/typesystemdata.h 5bf470c =

Diff: http://git.reviewboard.kde.org/r/100241/diff

Testing
-------

i did some personal testing, since i marked a pointer type, kdevelop will c=
hange a dot after an instance of this type to an arrow eventhough any of th=
e two is a syntactic error in itself. i didnt't check how .* is implemented=
... it also fixes a bug in which you have a type like int foo::* but kdevel=
op thinks its just int. ie kdevelop ignored the whole pointer to member thi=
ng, not anymore :)

Thanks,

Floris

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100241/">http://git.reviewboard.kde.org/r/100241/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Floris Ruijter.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">implementing the PtrToMemberType, type which represents \
pointer-to-member types ;) like int foo::* bar;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i did some personal testing, since i marked a pointer type, kdevelop \
will change a dot after an instance of this type to an arrow eventhough any of the \
two is a syntactic error in itself. i didnt&#39;t check how .* is implemented... it \
also fixes a bug in which you have a type like int foo::* but kdevelop thinks its \
just int. ie kdevelop ignored the whole pointer to member thing, not anymore :)</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>language/CMakeLists.txt <span style="color: grey">(67985db)</span></li>

 <li>language/duchain/types/alltypes.h <span style="color: \
grey">(e233985)</span></li>

 <li>language/duchain/types/pointertype.h <span style="color: \
grey">(deb40ed)</span></li>

 <li>language/duchain/types/ptrtomembertype.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>language/duchain/types/ptrtomembertype.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>language/duchain/types/typesystem.cpp <span style="color: \
grey">(941e541)</span></li>

 <li>language/duchain/types/typesystemdata.h <span style="color: \
grey">(5bf470c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100241/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 