From kdevelop-devel  Fri Dec 17 07:47:25 2010
From: Andreas Pakulat <apaku () gmx ! de>
Date: Fri, 17 Dec 2010 07:47:25 +0000
To: kdevelop-devel
Subject: Re: Killability of ImportProjectJob
Message-Id: <20101217074725.GB5982 () trinity ! apaku ! dnsalias ! org>
X-MARC-Message: https://marc.info/?l=kdevelop-devel&m=129257229928102

On 17.12.10 12:20:50, Olivier JG wrote:
> On 12/17/2010 12:14 PM, Aleix Pol wrote:
> >It works for cmake, if nobody changed it from back when I
> >implemented it, at least.
> Could you try to reload Kdevelop and press stop? That just hangs
> every time for me, and based on what the Qt docs say, there's no
> reason for it to do anything else.

Then you've got a bug somewhere else. The job doesn't try to kill the
QtConcurrent-thing (well it does, but it doesn't rely on that). Instead
it relies on a flag to tell the import-function that it shouldn't
recurse anymore and hence the job will end eventually and won't parse
the rest. This can potentially take a bit, depending on how far it got
already.

Oh and the fact that this flag is not protected is also not good of
course...

And of course it works just fine here trying to open and cancel loading
of KDevPlatform :)

Andreas

-- 
Make a wish, it might come true.

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel