[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: [kdevplatform] a5caf03: Make it possible to add pre-configured
From: Aleix Pol <aleixpol () kde ! org>
Date: 2010-10-24 22:15:52
Message-ID: AANLkTi=QRWukk6cKfquRFWj50fCZV7L6UQ8fD92EZo+c () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I agree that it doesn't scale, I disagree on that we want a wizard.
Reasoning: we don't want a wizard to do the same as the dialog, the only
problem of the dialog is that people is too lazy to use it, so just adding
actions to create lauchers by default is both useful and simple.
Plan: I'll expose QMenu's instead of a list of QAction to provide project
granularity and maybe FS if necessary.
If we ever revive veritas test framework probably, we could remove tests
from this dialog, which would be good too.
Aleix
On Sun, Oct 24, 2010 at 12:51 AM, Milian Wolff <mail@milianw.de> wrote:
> On Friday 22 October 2010 09:03:05 Andreas Pakulat wrote:
> > On 21.10.10 21:51:02, Aleix Pol wrote:
> > > diff --git a/plugins/execute/nativeappconfig.cpp
> > > b/plugins/execute/nativeappconfig.cpp index 5edb957..7aadbfc 100644
> > > --- a/plugins/execute/nativeappconfig.cpp
> > > +++ b/plugins/execute/nativeappconfig.cpp
> > > @@ -395,5 +395,64 @@ void
> > > NativeAppConfigType::configureLaunchFromCmdLineArguments ( KConfigGroup
> > > cfg
> > >
> > > cfg.sync();
> > >
> > > }
> > >
> > > +QList<KDevelop::ProjectTargetItem*>
> > > targetsInFolder(KDevelop::ProjectFolderItem* folder) +{
> > > + QList<KDevelop::ProjectTargetItem*> ret;
> > > + foreach(KDevelop::ProjectFolderItem* f, folder->folderList())
> > > + ret += targetsInFolder(f);
> > > +
> > > + ret += folder->targetList();
> > > + return ret;
> > > +}
> > > +
> > > +QList<QAction*> NativeAppConfigType::launcherSuggestions()
> > > +{
> > > + static QList<QAction*> ret;
> > > + if(!ret.isEmpty())
> > > + return ret;
> > > +
>
> Hijacking thread:
>
> Sorry to say Aleix, but what you implemented there does not scale. Open
> more
> projects and the dropdown will easily fill your whole screen.
>
> I also dislike the place where this is implemented.
>
> Imo we should make the launch config dialog a real wizard and keep the
> current
> thingy to edit exiting configs.
>
> I imagine a big fat easy to understand button "add new config" that then
> asks
> me:
>
> a) what project
> b) what executable
> c) dependencies
> d) optional debugger settings
>
> bye
> --
> Milian Wolff
> mail@milianw.de
> http://milianw.de
>
> --
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
[Attachment #5 (text/html)]
I agree that it doesn't scale, I disagree on that we want a \
wizard.<div><br></div><div>Reasoning: we don't want a wizard to do the same as \
the dialog, the only problem of the dialog is that people is too lazy to use it, so \
just adding actions to create lauchers by default is both useful and simple.</div> \
<div><br></div><div>Plan: I'll expose QMenu's instead of a list of QAction to \
provide project granularity and maybe FS if necessary.</div><div><br></div><div>If we \
ever revive veritas test framework probably, we could remove tests from this dialog, \
which would be good too.</div> <div><br></div><div>Aleix<br><br><div \
class="gmail_quote">On Sun, Oct 24, 2010 at 12:51 AM, Milian Wolff <span \
dir="ltr"><<a href="mailto:mail@milianw.de">mail@milianw.de</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">On Friday 22 October 2010 09:03:05 \
Andreas Pakulat wrote:<br> > On 21.10.10 21:51:02, Aleix Pol wrote:<br>
> > diff --git a/plugins/execute/nativeappconfig.cpp<br>
> > b/plugins/execute/nativeappconfig.cpp index 5edb957..7aadbfc 100644<br>
> > --- a/plugins/execute/nativeappconfig.cpp<br>
> > +++ b/plugins/execute/nativeappconfig.cpp<br>
> > @@ -395,5 +395,64 @@ void<br>
> > NativeAppConfigType::configureLaunchFromCmdLineArguments ( KConfigGroup<br>
> > cfg<br>
> ><br>
> > cfg.sync();<br>
> ><br>
> > }<br>
> ><br>
> > +QList<KDevelop::ProjectTargetItem*><br>
> > targetsInFolder(KDevelop::ProjectFolderItem* folder) +{<br>
> > + QList<KDevelop::ProjectTargetItem*> ret;<br>
> > + foreach(KDevelop::ProjectFolderItem* f, folder->folderList())<br>
> > + ret += targetsInFolder(f);<br>
> > +<br>
> > + ret += folder->targetList();<br>
> > + return ret;<br>
> > +}<br>
> > +<br>
> > +QList<QAction*> NativeAppConfigType::launcherSuggestions()<br>
> > +{<br>
> > + static QList<QAction*> ret;<br>
> > + if(!ret.isEmpty())<br>
> > + return ret;<br>
> > +<br>
<br>
</div>Hijacking thread:<br>
<br>
Sorry to say Aleix, but what you implemented there does not scale. Open more<br>
projects and the dropdown will easily fill your whole screen.<br>
<br>
I also dislike the place where this is implemented.<br>
<br>
Imo we should make the launch config dialog a real wizard and keep the current<br>
thingy to edit exiting configs.<br>
<br>
I imagine a big fat easy to understand button "add new config" that then \
asks<br> me:<br>
<br>
a) what project<br>
b) what executable<br>
c) dependencies<br>
d) optional debugger settings<br>
<br>
bye<br>
<font color="#888888">--<br>
Milian Wolff<br>
<a href="mailto:mail@milianw.de">mail@milianw.de</a><br>
<a href="http://milianw.de" target="_blank">http://milianw.de</a><br>
</font><br>--<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
<br></blockquote></div><br></div>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic