--===============0291943176==
Content-Type: multipart/signed;
  boundary="nextPart2369307.YIMGHFriyu";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2369307.YIMGHFriyu
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On Monday 19 July 2010 03:42:59 George Syron wrote:
>   While fixing the duplicates problem in the grepview plugin, I saw this:
> http://gitorious.org/kdevelop/kdevplatform/blobs/master/plugins/grepview/=
gr
> epjob.cpp#line205
>=20
> The things that came to my mind:
> "%s" is not a regexp, so why use QRegExp? The only answer is: people may
> search for "duplicate" with the pattern "%s\%s", which effectively
> searches for "duplicate%s", but the escaped %s is not handled, so the
> QRegExp should become "[^\\]%s" if I remember right.
>=20
> Are other patterns planned? If so, which would that be?
> Thanks for answers.

To me it looks like a simple replace, no QRegExp is needed for that. Simply=
=20
change it to

pattern.replace("%s", patternString);

Bye
=2D-=20
Milian Wolff
mail@milianw.de
http://milianw.de

--nextPart2369307.YIMGHFriyu
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAkxEKxcACgkQDA6yEs0dE5Mo1ACfULaYjRvyCHeeLfFLycGc9XB9
4UoAoK7KaLQbk0NU5PYwIxSMqTx0boGy
=bpmj
-----END PGP SIGNATURE-----

--nextPart2369307.YIMGHFriyu--


--===============0291943176==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

--===============0291943176==--