[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: extragear/sdk/kdevelop/app
From: David Nolden <zwabel () googlemail ! com>
Date: 2010-04-18 9:29:31
Message-ID: i2o6453d25e1004180229va14a41c9vb8e76119f6562188 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
The lock within notify only "locks" within the main thread (that's the
expression within the parens), and since the lock is recursive, this cannot
lead to a deadlock.
The release date is something we have to discuss separately.
Greetings, david
Am 18.04.2010 10:51 schrieb "Andreas Pakulat" <apaku@gmx.de>:
On 17.04.10 18:52:19, David Nolden wrote:
> 2010/4/17 Andreas Pakulat <apaku@gmx.de>:
> > On 17.04.1...
Yes it does something, it added a lock in QApp::notify. Did you test nested
event loops? Did you test separate threads with their own event loops? Did
you test sending events to objects in the main thread.
> it just makes the lock available. It is true that I'm just now working on
> actually using it in ...
Because it doesn't get enough testing. We're not even 2 weeks away from the
release and you're adding completely new code. Thats a risk to our
stability. As I said, its totally fine if you (and others) value this
important enough to do it (including the duchain porting). But I'm stopping
my maintainership around May 1st, wether we release 4.0 at that point or
not.
Andreas
--
You will be traveling and coming into a fortune.
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailma...
[Attachment #5 (text/html)]
<p>The lock within notify only "locks" within the main thread (that's \
the expression within the parens), and since the lock is recursive, this cannot lead \
to a deadlock.</p> <p>The release date is something we have to discuss \
separately.</p> <p>Greetings, david </p>
<p><blockquote type="cite">Am 18.04.2010 10:51 schrieb "Andreas Pakulat" \
<<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>>:<br><br><p><font \
color="#500050">On 17.04.10 18:52:19, David Nolden wrote:<br>> 2010/4/17 Andreas \
Pakulat <<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>>:<br> > > On \
17.04.1...</font></p>Yes it does something, it added a lock in QApp::notify. Did you \
test nested<br> event loops? Did you test separate threads with their own event \
loops? Did<br> you test sending events to objects in the main thread.<br>
<p><font color="#500050"><br>> it just makes the lock available. It is true that \
I'm just now working on<br>> actually using it in ...</font></p>Because it \
doesn't get enough testing. We're not even 2 weeks away from the<br>
release and you're adding completely new code. Thats a risk to our<br>
stability. As I said, its totally fine if you (and others) value this<br>
important enough to do it (including the duchain porting). But I'm stopping<br>
my maintainership around May 1st, wether we release 4.0 at that point or<br>
not.<br>
<br>
Andreas<br>
<font color="#888888"><br>
--<br>
You will be traveling and coming into a fortune.<br>
</font><p><font color="#500050"><br>-- <br>KDevelop-devel mailing list<br><a \
href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br><a \
href="https://barney.cs.uni-potsdam.de/mailma.">https://barney.cs.uni-potsdam.de/mailma.</a>..</font></p>
</blockquote></p>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic