[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: KDE/kdevplatform/plugins/projectmanagerview
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2009-07-08 18:45:47
Message-ID: 757d9a550907081145ld3a7b63r2e88e74a1b0c0eb4 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Jul 8, 2009 at 8:38 PM, Andreas Pakulat <apaku@gmx.de> wrote:

> On 08.07.09 18:20:44, Aleix Pol Gonzalez wrote:
> > SVN commit 993469 by apol:
> >
> > Do not assert and return a null pointer instead so that we don't get a
> crash in case that you press build when it's reloading or something like
> that.
>
> Uhm, without more context from the diff (don't have sources available atm):
> Why do we reach this code at all if the item to be built is not available
> in the tree. If an item is being reloaded the build actions should be
> disabled if that item is selected. If the item is part of a buildset, then
> the building should either also be disabled or the buildset should build
> all but this item.
>
> Andreas
>
> --
> You will hear good news from one you thought unfriendly to you.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

I see your point but i can't see why would that make the user experience
better. He would just get flickering while reloading the project.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Wed, Jul 8, 2009 at 8:38 PM, Andreas Pakulat <span \
dir="ltr">&lt;<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On 08.07.09 \
18:20:44, Aleix Pol Gonzalez wrote:<br> &gt; SVN commit 993469 by apol:<br>
&gt;<br>
&gt; Do not assert and return a null pointer instead so that we don&#39;t get a crash \
in case that you press build when it&#39;s reloading or something like that.<br> <br>
</div>Uhm, without more context from the diff (don&#39;t have sources available \
atm):<br> Why do we reach this code at all if the item to be built is not \
available<br> in the tree. If an item is being reloaded the build actions should \
be<br> disabled if that item is selected. If the item is part of a buildset, then<br>
the building should either also be disabled or the buildset should build<br>
all but this item.<br>
<br>
Andreas<br>
<font color="#888888"><br>
--<br>
You will hear good news from one you thought unfriendly to you.<br>
<br>
_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
 </font></blockquote></div><br>I see your point but i can&#39;t see why would that \
make the user experience better. He would just get flickering while reloading the \
project.<br>



_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]