[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    DVCS plugin interface
From:       Hugo Parente Lima <hugo.pl () gmail ! com>
Date:       2009-06-21 15:54:46
Message-ID: 200906211254.54078.hugo.pl () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi, I'm trying to get the git plugin usable in kdev4 and have some doubts 
about DVCS plugins and VCS plugins in general, here we go:

DVCS plugin have some pieces of code that are not called from anywhere and 
some methods that don't need to be different from VCS plugin. e.g.:

KDevelop::DistributedVersionControlPlugin has a pure virtual method:

void parseLogOutput(const DVcsJob * job,
                                QList<DVcsEvent>& revisions) const = 0;

that nobody calls, the git and mercurial (I think) plugins have 
implementations for this method, but useless implementations, because nobody 
calls it.


From kdevplatform/vcs/dvcs/ui I think that just the branch manager is used... 
and (I hope) the importmetadata widget. Some things like log view, commit view 
are redundant and IMO should use the code used in VCS plugins.


svn diff; git diff; etc is not working, maybe it could use the kompare kpart 
to display the diff.


To finish, the commit dialog could show the diff (kompare kpart) when you 
select a file in the file list, because a diff view precedes any good commit, 
and the place to do it is commit dialog.

Waiting for comments.

-- 
Hugo Parente Lima
"Precisamos de mais gênios humildes no mundo, hoje somos poucos!"
JID: hugo@jabber.org


["signature.asc" (application/pgp-signature)]

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]