[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: crash, bt and patch
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-04-18 6:46:40
Message-ID: 20090418064640.GG12248 () barmbek
[Download RAW message or body]

On 18.04.09 04:38:23, Jens Dagerbo wrote:
> I took a stroll through KDev4 tonight, and I must say it looks fantastic in 
> parts. Very impressive!
> 
> Of course it didn't take long to crash it though. After a while I figured out 
> what I was doing to cause it and reproduced it:
> 
> The following patch avoids the crash:
> Index: outputwidget.cpp
> ===================================================================
> --- outputwidget.cpp    (revision 955540)
> +++ outputwidget.cpp    (working copy)
> @@ -167,6 +167,7 @@
>                  stackwidget->removeWidget( w );
>              }
>              delete w;
> +            views.remove(id);
>          } else
>          {
>              views.value( id )->setModel( 0 );
> 
> 
> 
> I'm fairly certain the fix is correct and I still have an SVN account, but I 
> didn't want to commit anything without checking first.

I didn't test the patch, but it does seem reasonable and the surrounding
code doesn't seem to imply that the view shouldn't be removed. If you
don't notice any bugs whith the patch and multiple outputviews (for
example start more than one build), then please commit.

Andreas

-- 
Better hope the life-inspector doesn't come around while you have your
life in such a mess.

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread]