[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Review Request: generic NormalDeclarationCompletionItem in
From:       "Niko Sams" <niko.sams () gmail ! com>
Date:       2009-03-01 11:25:48
Message-ID: 20090301112548.18458.22664 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/210/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

I abstracted NormalDeclarationCompletionItem into kdevplatform so it can be used by \
other languages. The patch changes also cpp to use the new base class.


Diffs
-----

  trunk/KDE/kdevelop/languages/cpp/codecompletion/context.cpp 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/helpers.cpp 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/implementationhelperitem.cpp 933539 \
  trunk/KDE/kdevelop/languages/cpp/codecompletion/item.h 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/item.cpp 933539 
  trunk/KDE/kdevelop/tools/coverage/CMakeLists.txt 933539 
  trunk/KDE/kdevplatform/language/CMakeLists.txt 933539 
  trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.h \
PRE-CREATION   trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp \
PRE-CREATION 

Diff: http://reviewboard.kde.org/r/210/diff


Testing
-------

Unit-Tests pass, completion works.


Thanks,

Niko


_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]