[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Reviewboard
From: Aleix Pol <aleixpol () kde ! org>
Date: 2009-02-04 15:09:04
Message-ID: 757d9a550902040709y15d14981x171c1c0dba408cae () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Feb 4, 2009 at 11:24 AM, Andreas Pakulat <apaku@gmx.de> wrote:
> On 04.02.09 02:00:59, Aleix Pol wrote:
> > We should state first what cases are required to pass through this review
> > process.
> >
> > I don't think it is worth to pass all fixes through the commit review.
>
> Of course not. As I said we've always done few pre-commit reviews, most of
> the time for new interfaces to be added to kdevplatform.
>
> In general I think the rule of thumb when to post something for review is:
>
> - you have little idea about the code you're changing
> - its new public API for kdevplatform and you're not the "quasi" maintainer
> of the existing API (i.e. David doesn't need review for changes in
> language/)
> - anything else you don't feel comfortable with comitting without someone
> else having a look at. Things were you'd just like to get some feedback
> on wether you're on the right track/what do others think.
>
> Does that sound sane?
>
> Andreas
>
> --
> There is a fly on your nose.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
Works for me, as long as there are no strong rules on that.
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Wed, Feb 4, 2009 at 11:24 AM, Andreas Pakulat \
<span dir="ltr"><<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On 04.02.09 \
02:00:59, Aleix Pol wrote:<br> > We should state first what cases are required to \
pass through this review<br> > process.<br>
><br>
> I don't think it is worth to pass all fixes through the commit review.<br>
<br>
</div>Of course not. As I said we've always done few pre-commit reviews, most \
of<br> the time for new interfaces to be added to kdevplatform.<br>
<br>
In general I think the rule of thumb when to post something for review is:<br>
<br>
- you have little idea about the code you're changing<br>
- its new public API for kdevplatform and you're not the "quasi" \
maintainer<br> of the existing API (i.e. David doesn't need review for \
changes in<br> language/)<br>
- anything else you don't feel comfortable with comitting without someone<br>
else having a look at. Things were you'd just like to get some \
feedback<br> on wether you're on the right track/what do others think.<br>
<br>
Does that sound sane?<br>
<br>
Andreas<br>
<font color="#888888"><br>
--<br>
There is a fly on your nose.<br>
</font><div><div></div><div class="Wj3C7c"><br>
_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
</div></div></blockquote></div><br>Works for me, as long as there are no strong \
rules on that.<br>
_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic