[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: cmake single file build issues
From: Aleix <aleixpol () gmail ! com>
Date: 2008-11-25 12:43:33
Message-ID: 757d9a550811250443h7598820s6af689621f655696 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I'll take a look at it this evening
On Tue, Nov 25, 2008 at 11:34 AM, Andreas Pakulat <apaku@gmx.de> wrote:
> On 25.11.08 09:44:15, Manuel Breugelmans wrote:
> > On Monday 24 November 2008 18:09:28 Andreas Pakulat wrote:
> > > On 24.11.08 16:29:18, Manuel Breugelmans wrote:
> > > > This is does not work as expected, see
> > > > https://bugs.kde.org/show_bug.cgi?id=175994
> > > >
> > > > There's a couple more subtle issues with this code.
> > > > 1/ Now you can do README -> compile and it will try to run `make
> > > > README.o' 2/ The deletion code (m_deleteWhenDone
> cmakebuilder.cpp:91;111)
> > > > is not safe. It deletes a ProjectTargetItem in the event loop, the
> same
> > > > item that is exposed through the built(ProjectBaseItem*) signals. So
> > > > anyone accessing this is fooked.
> > > >
> > > > I think all 3 problems could be fixed with a 'FileTarget' in the
> project
> > > > model.
> > >
> > > The problem is that we don't really want the target in the model, or do
> you
> > > mean a mix of FileItem+TargetItem? I don't really see why that would be
> > > needed.
> > >
> > > I mean why can't the Makebuilder do the dirty work here? It gets a
> project
> > > item, so it can:
> > >
> > > - fetch the builddir for that item (which probably needs some fixing in
> > > cmake manager)
> > > - run make item.name().replace(".cpp",".o")
> > >
> > > Where the replace would actually be configurable somehow (or use
> > > information about the compiler, msvc/mingw create .obj usually).
> > >
> >
> > Currently this replace happens in cmakebuilder. Not sure if there was a
> > particular reason for that. You'd have to ask aliex ...
>
> I recall having discussed this with him and I don't quite understand why I
> thought this would need handling in the cmakebuilder.
>
> Andreas
>
> --
> You are fairminded, just and loving.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
[Attachment #5 (text/html)]
I'll take a look at it this evening<br><br><div class="gmail_quote">On Tue, Nov \
25, 2008 at 11:34 AM, Andreas Pakulat <span dir="ltr"><<a \
href="mailto:apaku@gmx.de">apaku@gmx.de</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div><div></div><div class="Wj3C7c">On 25.11.08 \
09:44:15, Manuel Breugelmans wrote:<br> > On Monday 24 November 2008 18:09:28 \
Andreas Pakulat wrote:<br> > > On 24.11.08 16:29:18, Manuel Breugelmans \
wrote:<br> > > > This is does not work as expected, see<br>
> > > <a href="https://bugs.kde.org/show_bug.cgi?id=175994" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=175994</a><br> > > \
><br> > > > There's a couple more subtle issues with this code.<br>
> > > 1/ Now you can do README -> compile and it will try to run \
`make<br> > > > README.o' 2/ The deletion code (m_deleteWhenDone \
cmakebuilder.cpp:91;111)<br> > > > is not safe. It deletes a \
ProjectTargetItem in the event loop, the same<br> > > > item that is exposed \
through the built(ProjectBaseItem*) signals. So<br> > > > anyone accessing \
this is fooked.<br> > > ><br>
> > > I think all 3 problems could be fixed with a 'FileTarget' in \
the project<br> > > > model.<br>
> ><br>
> > The problem is that we don't really want the target in the model, or do \
you<br> > > mean a mix of FileItem+TargetItem? I don't really see why that \
would be<br> > > needed.<br>
> ><br>
> > I mean why can't the Makebuilder do the dirty work here? It gets a \
project<br> > > item, so it can:<br>
> ><br>
> > - fetch the builddir for that item (which probably needs some fixing in<br>
> > cmake manager)<br>
> > - run make <a href="http://item.name" \
target="_blank">item.name</a>().replace(".cpp",".o")<br> > \
><br> > > Where the replace would actually be configurable somehow (or \
use<br> > > information about the compiler, msvc/mingw create .obj \
usually).<br> > ><br>
><br>
> Currently this replace happens in cmakebuilder. Not sure if there was a<br>
> particular reason for that. You'd have to ask aliex ...<br>
<br>
</div></div>I recall having discussed this with him and I don't quite understand \
why I<br> thought this would need handling in the cmakebuilder.<br>
<br>
Andreas<br>
<font color="#888888"><br>
--<br>
You are fairminded, just and loving.<br>
</font><div><div></div><div class="Wj3C7c"><br>
_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
</div></div></blockquote></div><br>
_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic