[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Replacing QRegExp with CMake RegularExpression
From:       Aleix <aleixpol () gmail ! com>
Date:       2008-11-02 14:16:16
Message-ID: 757d9a550811020616w145b812em3eff1a1b2d4946b8 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi, looks like a pretty small patch, I'm ok with using it, makes sense to
me.

On Sun, Nov 2, 2008 at 2:59 AM, Andreas Pakulat <apaku@gmx.de> wrote:

> Hi,
>
> so I thought it might be interesting to try this out. Turned out to be a
> bit more complex than I initially thought and unfortunately it also
> introduces one regression with the kde4addunittest test. (I'm seeing an
> error message from RegularExpression about nested "*?+", so that might be a
> hint).

We might have to tweak the library usage maybe, but i think that we are on
the right path here.


>
> Having done a quick time kdevelop like test the startup speed of kdevelop
> including loading of kdevplatform was reduced frmo 15 to 11 seconds on my
> old machine.
>
Great!


>
> The patch is attached for anyone to look at, whats a bit scary is the
> conversion between QString and char* for the RegularExpression class. I'm
> actually thinking about seeing wether converting to QChar helps with that
> or wether using that class drains performance again.
>
.toAscii() works for me, why passing through QChar?


>
> Andreas
>
> --
> You have the power to influence all with whom you come in contact.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel@kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>

[Attachment #5 (text/html)]

Hi, looks like a pretty small patch, I&#39;m ok with using it, makes sense to \
me.<br><br><div class="gmail_quote">On Sun, Nov 2, 2008 at 2:59 AM, Andreas Pakulat \
<span dir="ltr">&lt;<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br> <br>
so I thought it might be interesting to try this out. Turned out to be a<br>
bit more complex than I initially thought and unfortunately it also<br>
introduces one regression with the kde4addunittest test. (I&#39;m seeing an<br>
error message from RegularExpression about nested &quot;*?+&quot;, so that might be \
a<br> hint).&nbsp;</blockquote><div>We might have to tweak the library usage maybe, \
but i think that we are on the right path here.<br>&nbsp;<br></div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <br>
Having done a quick time kdevelop like test the startup speed of kdevelop<br>
including loading of kdevplatform was reduced frmo 15 to 11 seconds on my<br>
old machine.<br>
</blockquote><div>Great!<br>&nbsp;<br></div><blockquote class="gmail_quote" \
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;"><br> The patch is attached for anyone to look at, whats a bit \
scary is the<br> conversion between QString and char* for the RegularExpression \
class. I&#39;m<br> actually thinking about seeing wether converting to QChar helps \
with that<br> or wether using that class drains performance again.<br>
</blockquote><div>.toAscii() works for me, why passing through \
QChar?<br>&nbsp;<br></div><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br> \
Andreas<br> <font color="#888888"><br>
--<br>
You have the power to influence all with whom you come in contact.<br>
</font><br>_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kdevelop.org">KDevelop-devel@kdevelop.org</a><br>
<a href="https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel" \
target="_blank">https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel</a><br>
 <br></blockquote></div><br>



_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]