[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: A test session with the current kdevelop
From:       Alexander Dymo <dymo () mk ! ukrtelecom ! ua>
Date:       2006-10-20 17:37:17
Message-ID: 200610202037.17563.dymo () mk ! ukrtelecom ! ua
[Download RAW message or body]

On Wednesday 18 October 2006 02:05, Matthew Woehlke wrote:
> Well then this needs to be reassigned to whoever maintains bluecurve
> (and someone does, it changed - and not IMO for the better - when I
> finally moved to kde 3.5.5), and/or KDevelop needs to rethink how it
> creates tabs.
The width of simple ideal button is calculated with QStyle::CT_ToolButton
contents type and not with CT_PushButton like kmdi does.
In most styles that makes the simpleideal button _smaller_.
Maybe that is the problem with bluecurve. Could you please try my newui patch?

> This also doesn't address that we've lost dynamic resizing of the
> docking windows, which IMO is a step backwards.
Sorry, I don't know the easy way to do that. I'll try to find it.
Same for the width of resize handles (but I doublt I'll change them,
4px is too small).

["newui.patch" (text/x-diff)]

Index: button.cpp
===================================================================
--- button.cpp	(revision 595526)
+++ button.cpp	(working copy)
@@ -223,8 +223,11 @@
             h = QMAX(h, sz.height());
     }
 
-    return (style().sizeFromContents(QStyle::CT_ToolButton, this, QSize(w, h)).
-            expandedTo(QApplication::globalStrut()));
+    QSize sz1 = style().sizeFromContents(QStyle::CT_ToolButton, this, QSize(w, h)).
+            expandedTo(QApplication::globalStrut());
+    QSize sz2 = style().sizeFromContents(QStyle::CT_PushButton, this, QSize(w, h)).
+            expandedTo(QApplication::globalStrut());
+    return sz1.height() < sz2.height() ? sz1 :sz2 ;
 }
 
 void Button::updateSize()


_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@barney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]