[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    [PATCH] fix library link order in qmake manager
From:       Andreas Koepfle <koepfle () ti ! uni-mannheim ! de>
Date:       2003-08-05 13:52:49
[Download RAW message or body]

Hi,
I'm porting some projects to work with gideons qmake manager and I found a 
problem with the library link order.

If a project links to internal and external libraries, qmake manager puts the 
external libs before the internal libs on the LIBS line in the *.pro file.
However as your internal libraries may depend on the external ones (like e.g. 
SDL,...) the external libs have to come after the internal ones for the 
linker to resolve the dependencies.

This patch just switches the order of the libs when building the LIBS line.

Andreas

["patch-lib-order" (text/x-diff)]

Index: parts/trollproject/projectconfigurationdlg.cpp 
=================================================================== 
RCS file: /home/kde/kdevelop/parts/trollproject/projectconfigurationdlg.cpp,v 
retrieving revision 1.28 
diff -u -3 -p -r1.28 projectconfigurationdlg.cpp 
--- parts/trollproject/projectconfigurationdlg.cpp	4 Aug 2003 21:52:54 -0000	1.28 
+++ parts/trollproject/projectconfigurationdlg.cpp	5 Aug 2003 13:15:54 -0000 
@@ -200,13 +200,6 @@ void ProjectConfigurationDlg::updateProj 
   myProjectItem->configuration.m_libadd.clear(); 
   myProjectItem->configuration.m_librarypath.clear(); 
  
-  //outside libs to link 
-  outsideItem=(QCheckListItem *)outsidelib_listview->firstChild(); 
-  while(outsideItem) 
-  { 
-    myProjectItem->configuration.m_libadd.append(outsideItem->text(0)); 
-    outsideItem=(QCheckListItem*)outsideItem->itemBelow(); 
-  } 
  
   //inside libs to link 
 //  myProjectItem->configuration.m_prjdeps.clear(); 
@@ -230,6 +223,14 @@ void ProjectConfigurationDlg::updateProj 
  
     } 
     insideItem=(InsideCheckListItem*)insideItem->itemBelow(); 
+  } 
+ 
+  //outside libs to link 
+  outsideItem=(QCheckListItem *)outsidelib_listview->firstChild(); 
+  while(outsideItem) 
+  { 
+    myProjectItem->configuration.m_libadd.append(outsideItem->text(0)); 
+    outsideItem=(QCheckListItem*)outsideItem->itemBelow(); 
   } 
  
   //external project dependencies 
 

_______________________________________________
Kdevelop-devel mailing list
Kdevelop-devel@barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread]