[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Bug#44111: C Compiler Options ignored (CFLAGS)
From:       "W. Tasin" <tasin () fhm ! edu>
Date:       2002-06-20 13:48:00
[Download RAW message or body]

Hi *,

to review the patch which solves this bug.

Plz check/review and commit....

Ciao

Walter

harald.nikolisin@sofistik.de wrote:

>Package: kdevelop
>Version: 2.1.1 (using KDE 3.0.1 )
>Severity: normal
>Installed from:    SuSE RPMs
>Compiler:          gcc version 2.95.3 20010315 (SuSE)
>OS:                Linux
>OS/Compiler notes: Not Specified
>
>Unfortunately the C Compiler Flags (CFLAGS) are ignored.
>  
>
....

-- 
oohhh sveglia.... il mondo e' ammalato, ma x colpa di chi.........
(Zucchero)
:-------W._Tasin,_FB_04,_FHM-------------------PGP-KeyID:0x7961A645---:
<Key-Fingerprint: 1610 835F 0080 32F4 6140  6CF7 A7D0 44CD 7961A645>
<http://wwwkeys.pgp.net:11371/pks/lookup?op=index&search=0x7961A645&fingerprint=on>



["cflags.patch" (text/plain)]

Index: kdevelop/ckdevelop.cpp
===================================================================
RCS file: /home/kde/kdevelop/kdevelop/ckdevelop.cpp,v
retrieving revision 1.158.2.114.2.140.2.43
diff -u -r1.158.2.114.2.140.2.43 ckdevelop.cpp
--- kdevelop/ckdevelop.cpp	2002/06/11 23:53:03	1.158.2.114.2.140.2.43
+++ kdevelop/ckdevelop.cpp	2002/06/20 13:43:23
@@ -935,11 +935,20 @@
  	QString conf=compile_combo->currentText();
   QString flags, makefile;
 
+  /* Setting the flags (CPPFLAGS, CFLAGS, CXXFLAGS, ADDCXXFLAGS) here don't do anything 
+      unless the flags are part of the right side of the (g)make call
+      on the left side they are only informative and of interest for the debug output
+      so consider this code as obsolete, but it does no harm.
+      The setting of the flags is only done by the configure-call!!!
+      W. Tasin 20.06.2002
+  */
   if (prj->getProjectType()!="normal_empty")
   {
    	QString cppflags, cflags, cxxflags, addcxxflags, ldflags, group;
     if(conf==i18n("(Default)")){
 		  QDir::setCurrent(actualDir);
+   		cppflags=prj->getCPPFLAGS().simplifyWhiteSpace();
+   		cflags=prj->getCFLAGS().simplifyWhiteSpace();
    		cxxflags=prj->getCXXFLAGS().simplifyWhiteSpace();
    		addcxxflags=prj->getAdditCXXFLAGS().simplifyWhiteSpace();
    		ldflags=prj->getLDFLAGS().simplifyWhiteSpace();
@@ -1894,11 +1903,20 @@
  	QString conf=compile_combo->currentText();
   QString flags, makefile;
 
+ /* Setting the flags (CPPFLAGS, CFLAGS, CXXFLAGS, ADDCXXFLAGS) here don't do anything 
+      unless the flags are part of the right side of the (g)make call
+      on the left side they are only informative and of interest for the debug output
+      so consider this code as obsolete, but it does no harm.
+      The setting of the flags is only done by the configure-call!!!
+      W. Tasin 20.06.2002
+ */
   if (type!=CMakefile::cvs)
   {
    	QString cppflags, cflags, cxxflags, addcxxflags, ldflags, group;
     if(conf==i18n("(Default)")){
     	QDir::setCurrent(prj->getProjectDir());
+   		cppflags=prj->getCPPFLAGS().simplifyWhiteSpace();
+   		cflags=prj->getCFLAGS().simplifyWhiteSpace();
    		cxxflags=prj->getCXXFLAGS().simplifyWhiteSpace();
    		addcxxflags=prj->getAdditCXXFLAGS().simplifyWhiteSpace();
    		ldflags=prj->getLDFLAGS().simplifyWhiteSpace();
@@ -2119,6 +2137,8 @@
 	// get all other strings
   if(conf==i18n("(Default)"))
   {
+		cppflags=prj->getCPPFLAGS().simplifyWhiteSpace();
+		cflags=prj->getCFLAGS().simplifyWhiteSpace();
 		cxxflags=prj->getCXXFLAGS().simplifyWhiteSpace();
 		addcxxflags=prj->getAdditCXXFLAGS().simplifyWhiteSpace();
 		ldflags=prj->getLDFLAGS().simplifyWhiteSpace();
Index: kdevelop/ckdevelop_project.cpp
===================================================================
RCS file: /home/kde/kdevelop/kdevelop/ckdevelop_project.cpp,v
retrieving revision 1.82.2.47.2.72.2.20
diff -u -r1.82.2.47.2.72.2.20 ckdevelop_project.cpp
--- kdevelop/ckdevelop_project.cpp	2002/04/03 15:27:20	1.82.2.47.2.72.2.20
+++ kdevelop/ckdevelop_project.cpp	2002/06/20 13:43:23
@@ -422,6 +422,8 @@
   }
   else
   {
+     cppflags=prj->getCPPFLAGS().simplifyWhiteSpace();
+     cflags=prj->getCFLAGS().simplifyWhiteSpace();
      cxxflags=prj->getCXXFLAGS().simplifyWhiteSpace();
      addcxxflags=prj->getAdditCXXFLAGS().simplifyWhiteSpace();
      ldflags=prj->getLDFLAGS().simplifyWhiteSpace();

_______________________________________________
Kdevelop-devel mailing list
Kdevelop-devel@barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread]