[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 204399] crash in QAbstractItemView::sizeHintForRow / FocusedTreeView
From:       Milian Wolff <mail () milianw ! de>
Date:       2012-08-07 11:16:46
Message-ID: bug-204399-40295-3diQNa9zNz () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=204399

Milian Wolff <mail@milianw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kdev
                   |                            |platform/f5e397be7a8088a948
                   |                            |14a488133d572dc4167f14

--- Comment #24 from Milian Wolff <mail@milianw.de> ---
Git commit f5e397be7a8088a94814a488133d572dc4167f14 by Milian Wolff.
Committed on 07/08/2012 at 13:09.
Pushed by mwolff into branch 'master'.

Let the OutputView take ownership of a job's model and delegate.

This is required to ensure proper functionality of the views
when e.g. a plugin gets unloaded. Previously, this would trigger
crashes due to access of invalid model or delegate pointers.

Now the view will stay functioning even if e.g. the MakeBuilder
gets plugin gets unloaded after a project was compiled, or even
if you close a project while it is being built.

It is still safe to access both, the model and the delegate,
from inside a job as long as the job is running. When a view
gets closed, the job gets cancelled anyways.

Sadly, this is an ABI break and thus cannot be backported to
the KDevplatform 1.4 branch...
Related: bug 207669

M  +0    -1    outputview/CMakeLists.txt
D  +0    -38   outputview/delegateholder.cpp
D  +0    -44   outputview/delegateholder.h
M  +8    -18   outputview/ioutputview.h
M  +1    -1    outputview/outputdelegate.h
M  +4    -10   outputview/outputjob.cpp
M  +20   -4    outputview/outputjob.h
M  +1    -1    outputview/outputmodel.h
M  +1    -1    plugins/execute/nativeappjob.cpp
M  +1    -1    plugins/executescript/executescriptoutputmodel.h
M  +1    -2    plugins/executescript/executescriptplugin.cpp
M  +1    -2    plugins/executescript/executescriptplugin.h
M  +3    -3    plugins/executescript/scriptappjob.cpp
M  +0    -1    plugins/executescript/scriptappjob.h
M  +4    -3    plugins/externalscript/externalscriptjob.cpp
M  +0    -1    plugins/externalscript/externalscriptplugin.cpp
M  +1    -2    plugins/externalscript/externalscriptplugin.h
M  +1    -5    plugins/standardoutputview/outputwidget.cpp
M  +4    -4    plugins/standardoutputview/standardoutputview.cpp
M  +2    -2    plugins/standardoutputview/standardoutputview.h
M  +10   -20   plugins/standardoutputview/tests/standardoutputviewtest.cpp
M  +0    -4    plugins/standardoutputview/tests/standardoutputviewtest.h
M  +13   -8    plugins/standardoutputview/toolviewdata.cpp
M  +3    -5    plugins/standardoutputview/toolviewdata.h
M  +2    -2    vcs/dvcs/dvcsjob.cpp

http://commits.kde.org/kdevplatform/f5e397be7a8088a94814a488133d572dc4167f14

-- 
You are receiving this mail because:
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]