[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 204399] crash in QAbstractItemView::sizeHintForRow / FocusedTreeView
From:       Milian Wolff <mail () milianw ! de>
Date:       2012-08-07 8:33:46
Message-ID: bug-204399-40295-e49zEAiKSV () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=204399

--- Comment #22 from Milian Wolff <mail@milianw.de> ---
a) The outputview is still referencing the delegate, because the view showing
the build-output is still there. The makebuilder plugin itself does not
explicitly register a view or anything, it just runs an outputjob (the
makejob). The job sets the delegate and the view uses that. And the view does
not really now anything about any plugin, it just nows something about an
OutputJob that will finish at some point. Even if the job has finished though,
we still want to show its output until the user deletes the view.

b) Imo it "wants" to keep the ownership because the API says that this is the
default and one gets the impression that it is thus the recommended way of
doing it. There is even the DelegateHolder in kdevplatform/outputview ...

All in all I think this is pretty wrong on the KDevplatform side. Afaik, a
delegate should actually have a one-to-one relation to a view, i.e. one should
not reuse a delegate for multiple views. That is done though, as far as I can
see. Every time you run an app, or a script, it will create a new view and
reuse the same delegate. And of course, unloading a plugin will then crash
kdevplatform.

For 4.4 this is probably too late to fix properly, yet I think for 4.5 I'll
remove the ownership feature and will put the ownership always to the view. So
far, I have not seen a single reason why the plugin should hold the ownership
here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]