[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 267877] cpp code completion: non-const methods hidden even when overload-resolution could find
From:       Milian Wolff <mail () milianw ! de>
Date:       2012-02-28 19:26:58
Message-ID: E1S2ShO-0007SW-Fz () bugs ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=267877


Milian Wolff <mail@milianw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from Milian Wolff <mail milianw de>  2012-02-28 19:26:58 ---
Git commit 50b8d362e01e0ed3fed8e875902e1595be31bb41 by Milian Wolff.
Committed on 28/02/2012 at 20:23.
Pushed by mwolff into branch '4.3'.

properly take constness during overload resolution into account

we prefer non-const overloads to const ones if we are accessing
a non-const object now, this is also what g++ does by default
as far as I can see

M  +13   -0    languages/cpp/cppduchain/expressionvisitor.cpp
M  +9    -4    languages/cpp/cppduchain/overloadresolution.cpp
M  +14   -2    languages/cpp/cppduchain/overloadresolution.h
M  +12   -3    languages/cpp/cppduchain/overloadresolutionhelper.cpp
M  +8    -1    languages/cpp/cppduchain/overloadresolutionhelper.h
M  +78   -0    languages/cpp/cppduchain/tests/test_expressionparser.cpp
M  +2    -0    languages/cpp/cppduchain/tests/test_expressionparser.h
M  +15   -1    languages/cpp/cppduchain/viablefunctions.cpp
M  +4    -1    languages/cpp/cppduchain/viablefunctions.h

http://commits.kde.org/kdevelop/50b8d362e01e0ed3fed8e875902e1595be31bb41

--- Comment #11 from Milian Wolff <mail milianw de>  2012-02-28 19:26:58 ---
Git commit 3a546dd106794dc12ce0cf6893b02142f566d2b3 by Milian Wolff.
Committed on 28/02/2012 at 20:21.
Pushed by mwolff into branch '4.3'.

properly take constness during code completion into account

- when accessing a const object, only show const methods
- when accessign a non-const object, prefer non-const overloads
to the const ones, but still show const methods if they are not overloaded

M  +11   -9    languages/cpp/codecompletion/context.cpp
M  +2    -2    languages/cpp/codecompletion/context.h
M  +40   -7    languages/cpp/cppduchain/cppduchain.cpp
M  +13   -5    languages/cpp/cppduchain/cppduchain.h
M  +52   -0    languages/cpp/tests/test_cppcodecompletion.cpp
M  +1    -0    languages/cpp/tests/test_cppcodecompletion.h

http://commits.kde.org/kdevelop/3a546dd106794dc12ce0cf6893b02142f566d2b3

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]