From kdevelop-bugs Tue Jul 26 21:54:25 2011 From: Andreas Pakulat Date: Tue, 26 Jul 2011 21:54:25 +0000 To: kdevelop-bugs Subject: [Bug 261519] CMake project configuration dialog works incorrect Message-Id: X-MARC-Message: https://marc.info/?l=kdevelop-bugs&m=131171739117196 https://bugs.kde.org/show_bug.cgi?id=261519 Andreas Pakulat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Andreas Pakulat 2011-07-26 21:54:25 --- Git commit 618eb5e13fd991921d38ae6e936d6836b94d25cf by Andreas Pakulat. Committed on 26/07/2011 at 21:41. Pushed by apaku into branch 'master'. Fix cleanup of cache-model Directly deleting the cache model and leaving a reference in the view is dangerous as the related bugreport shows. I'm not sure why there was an event sent out to the selectionmodel, but it seems this happens already when deleting the model. The event however is delivered later on in the nested event-loop from the kmessagebox and at that point the selectionmodel is already gone. So disconnect the selectionmodel properly, explicitly remove the model from the view and let the cache model alive for one round of event-processing. CCBUG: 261519 M +3 -1 projectmanagers/cmake/settings/cmakepreferences.cpp http://commits.kde.org/kdevelop/618eb5e13fd991921d38ae6e936d6836b94d25cf --- Comment #4 from Andreas Pakulat 2011-07-26 21:54:25 --- Git commit 7f5cc9fad784734a4656f755cd53462872d01394 by Andreas Pakulat. Committed on 26/07/2011 at 23:52. Pushed by apaku into branch 'master'. Fix creation of builddirs with custom cmake args This should fix all open problems configuring new builddirs and changing stuff in the builddir-creation dialog. It takes the values from the dialog and explicitly initializes the kconfigskeleton items from them. This ensures the values end up in the config file and we don't loose things set in the dialog. Also necessary for this is to pre-initialize the local variables in save so that there's no empty stuff written out in case no model has been created yet. Last add a TODO about the possibility to have different builddirs with different configs and not being able to re-run cmake from scratch for them, but thats something for another time. Probably would be useful to completely drop the kconfig-skeleton stuff since its not used anyway by the kcm and would make it more explicit that the module has to keep track of these things manually. BUG: 261519 M +37 -10 projectmanagers/cmake/settings/cmakepreferences.cpp http://commits.kde.org/kdevelop/7f5cc9fad784734a4656f755cd53462872d01394 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ KDevelop-bugs mailing list KDevelop-bugs@kdevelop.org https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs