[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 258285] KDevelop crashed when initiating build
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2010-11-29 18:58:34
Message-ID: 20101129185834.22182762C0 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=258285


Aleix Pol <aleixpol@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Aleix Pol <aleixpol kde org>  2010-11-29 19:58:32 ---
commit 4d05d482ccb38029b1e5604e2b1b3594c39b492c
branch master
Author: Aleix Pol <aleixpol@kde.org>
Date:   Mon Nov 29 19:45:34 2010 +0100

    Always check if the current item to retrieve the builddir from is a folder.

    BUG: 258285

diff --git a/projectmanagers/cmake/cmakemanager.cpp
b/projectmanagers/cmake/cmakemanager.cpp
index 5e8ac7d..b8c9b2a 100644
--- a/projectmanagers/cmake/cmakemanager.cpp
+++ b/projectmanagers/cmake/cmakemanager.cpp
@@ -165,17 +165,14 @@ KUrl
CMakeManager::buildDirectory(KDevelop::ProjectBaseItem *item) const
 {
     KUrl ret;
     ProjectBaseItem* parent = item->parent();
-    if (!parent) {
+    if (parent)
+        ret=buildDirectory(parent);
+    else
         ret=CMake::currentBuildDir(item->project());
-        
-        CMakeFolderItem *fi=dynamic_cast<CMakeFolderItem*>(item);
+    
+    CMakeFolderItem *fi=dynamic_cast<CMakeFolderItem*>(item);
+    if(fi)
         ret.addPath(fi->buildDir());
-    } else {
-        ret=buildDirectory(parent);
-        CMakeFolderItem *fi=dynamic_cast<CMakeFolderItem*>(item);
-        if(fi)
-            ret.addPath(fi->buildDir());
-    }
     return ret;
 }

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]