[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 243424] kdevelop crashes while parsing cmake list containing
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-09-27 12:52:38
Message-ID: 20100927125238.E373369564 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=243424


Milian Wolff <mail@milianw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Milian Wolff <mail milianw de>  2010-09-27 14:52:37 ---
commit eef815585a4271d80220394556ed44af643e03f9
Author: Milian Wolff <mail@milianw.de>
Date:   Mon Sep 27 14:46:07 2010 +0200

    don't try to execute empty command

    BUG: 243424

diff --git a/projectmanagers/cmake/parser/cmakeprojectvisitor.cpp
b/projectmanagers/cmake/parser/cmakeprojectvisitor.cpp
index 67bfdbf..b9c5379 100644
--- a/projectmanagers/cmake/parser/cmakeprojectvisitor.cpp
+++ b/projectmanagers/cmake/parser/cmakeprojectvisitor.cpp
@@ -1327,6 +1327,11 @@ int CMakeProjectVisitor::visit(const ExecuteProcessAst
*exec)
     QList<KProcess*> procs;
     foreach(const QStringList& _args, exec->commands())
     {
+        if (_args.isEmpty())
+        {
+            kDebug(9032) << "Error: trying to execute empty command";
+            break;
+        }
         QStringList args(_args);
         KProcess *p=new KProcess(), *prev=0;
         if(!procs.isEmpty())

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]