[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 219206] Crash in workingset controller after switching to empty
From:       Niko Sams <niko.sams () gmail ! com>
Date:       2010-08-23 14:24:51
Message-ID: 20100823142451.A8A61615EC () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=219206





--- Comment #7 from Niko Sams <niko sams gmail com>  2010-08-23 16:24:50 ---
commit 18396c73306b9ffc7fd0f6dd51ca835d613089ab
Author: Niko Sams <niko.sams@gmail.com>
Date:   Wed Aug 11 21:47:29 2010 +0200

    Don't save empty workingset

    fixes assert
    BUG: 219206

diff --git a/shell/workingsetcontroller.cpp b/shell/workingsetcontroller.cpp
index f650a6a..148192e 100644
--- a/shell/workingsetcontroller.cpp
+++ b/shell/workingsetcontroller.cpp
@@ -664,7 +664,7 @@ void WorkingSet::changingWorkingSet(Sublime::Area* area,
QString from, QString t
     if (from == to)
         return;
     Q_ASSERT(m_areas.contains(area));
-    saveFromArea(area, area->rootIndex());
+    if (!m_id.isEmpty()) saveFromArea(area, area->rootIndex());
     disconnectArea(area);
     WorkingSet* newSet =
Core::self()->workingSetControllerInternal()->getWorkingSet(to);
     newSet->connectArea(area);

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic