[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 245774] Patch enabling code completion through global namespace
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-07-26 12:09:24
Message-ID: 20100726120931.786AA3E38 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=245774





--- Comment #1 from Milian Wolff <mail milianw de>  2010-07-26 14:09:20 ---
Please also provide two unit tests, one for code completion, one for proper
duchain integration. See cpp/duchain/tests/test_duchain.{cpp,h} and
cpp/test_cppcodecompletion.{cpp,h}.

Then finally please put that into a proper merge request on Gitorious. Clone
KDevelop, commit the changes then file a merge request by hitting the button on
the page of your clone.

For further questions, please find me on #kdevelop or use our developing
mailinglist.

Thanks for the contribution already, looks good. A few comments thought hat you
should remove first though:

- you add quite a few kDebug statements, are they really required? I'd be
tempted to remove them again.

- you shouldn't remove items while using a foreach, better use stl-style
iterators and use .erase() and friends (the foreach loops in the while loops).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs
[prev in list] [next in list] [prev in thread] [next in thread]