[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 243113] New: PHP plugin : class KDevelop::ProjectFolderItem has
From:       jay <jay () jay ! cz>
Date:       2010-06-29 7:02:43
Message-ID: bug-243113-40295 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=243113

           Summary: PHP plugin : class KDevelop::ProjectFolderItem has no
                    member named isProjectRoot
           Product: kdevelop
           Version: SVN
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Language Support: PHP
        AssignedTo: kdevelop-bugs@kdevelop.org
        ReportedBy: jay@jay.cz


Version:           SVN (using KDE 4.4.4) 
OS:                Linux

Current Git php plugin compile:
/opt/kdev/kde4/php/completion/context.cpp:1143: error: ‘class
KDevelop::ProjectFolderItem' has no member named ‘isProjectRoot'


isProjectRoot() was removed in
http://gitorious.org/kdevelop/kdevplatform/commit/aa00f59f97c048afa855835e935ca39c957c1d17


Reproducible: Always




According to comment "///@todo Why is this needed at all? Shouldn't it equal
"parent() == 0" ?"
I tryed to change:

]$ git diff completion/context.cpp
diff --git a/completion/context.cpp b/completion/context.cpp
index 2c4ba00..b6cf263 100644
--- a/completion/context.cpp
+++ b/completion/context.cpp
@@ -1140,7 +1140,7 @@ QList<CompletionTreeItemPointer>
CodeCompletionContext::completionItems(bool& ab
                     }
                     items << CompletionTreeItemPointer(new
IncludeFileItem(item));
                 }
-                if ( !folder->isProjectRoot() && !addedParentDir &&
m_expression.isEmpty() ) {
+                if ( !folder->parent() && !addedParentDir &&
m_expression.isEmpty() ) {
                     // expect a parent dir
                     IncludeItem item;
                     item.isDirectory = true;



First time compiled ok,
but now I have duchain error.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
KDevelop-bugs mailing list
KDevelop-bugs@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-bugs

[prev in list] [next in list] [prev in thread] [next in thread]