[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 121950] New: kde version check is wrong
From:       kdevelop-bugs-admin () barney ! cs ! uni-potsdam ! de
Date:       2006-02-14 11:20:29
Message-ID: 20060214122026.121950.stefaan.deroeck () gmail ! com
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121950         
           Summary: kde version check is wrong
           Product: kdevelop
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: kdevelop-bugs kdevelop org
        ReportedBy: stefaan.deroeck gmail com


Version:           kdevelop 3.3.1 (using KDE KDE 3.5.1KDE 1.2)
Installed from:    Compiled From SourcesCompiled From Sources
OS:                Linux

Judging by

http://developer.kde.org/documentation/library/3.3-api/kdeui/html/classKStdGuiItem.html
and
http://developer.kde.org/documentation/library/3.4-api/kdeui/html/classKStdGuiItem.html
the following patch seems to be in order (needed it to compile kdevelop 3.3.1 cleanly against kde 3.3):

--- orig/kdevelop-3.3.1/./vcs/cvsservice/cvspartimpl.cpp        2005-09-10 10:22:22.000000000 +0200
+++ work/kdevelop-3.3.1/./vcs/cvsservice/cvspartimpl.cpp        2006-02-14 11:59:52.000000000 +0100
 @ -840,7 +840,7  @
     int s = KMessageBox::questionYesNo( 0,
         i18n("Do you want to be added to CVS repository too?"),
         i18n("CVS - New Files Added to Project"),
-#if KDE_VERSION >= KDE_MAKE_VERSION(3,3,0)
+#if KDE_VERSION >= KDE_MAKE_VERSION(3,4,0)
         KStdGuiItem::add(),
 #else
         i18n( "Add Files"),


[prev in list] [next in list] [prev in thread] [next in thread]