[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 95409] Disabling breakpoints does not work
From:       kdevelop-bugs-admin () barney ! cs ! uni-potsdam ! de
Date:       2004-12-22 20:41:28
Message-ID: 20041222204128.6182.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=95409        
rgruber users sourceforge net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From rgruber users sourceforge net  2004-12-22 \
21:41 ------- CVS commit by rgruber: 

Fixed problem that disabled breakpoints do not get disabled if
starting debugger the first time since loading the project.
BUG: 95409


  M +20 -0     gdbbreakpointwidget.cpp   1.18


--- kdevelop/languages/cpp/debugger/gdbbreakpointwidget.cpp  #1.17:1.18
 @ -591,7 +591,27  @ void GDBBreakpointWidget::slotParseGDBBr
         if (id)
         {
+            /** rgruber:
+             * We set the needDisable flag if the breakpoint has been \
added and should be  +             * disabled at the same time. This can \
happen if you open a project which has  +             * a disabled \
breakpoint. Because setActive() resets some flags to false, we  +           \
* reenable them before emit publishBPState() and set them back after \
comming back. +             * This can only happen right after the \
breakpoint has been set. At any later time +             * bp->dbgId() will \
already have an id set. +             */
+            bool needDisable = (bp->dbgId() == -1 && bp->changedEnable() \
&& !bp->isEnabled());  bp->setActive(m_activeFlag, id);
             bp->setHardwareBP(hardware);
+            if (needDisable) {
+                                kdDebug(9012) << "Added breakpoint will be \
disabled! resetting flags..." << endl; +                \
bp->setEnabled(true); +                bp->setEnabled(false);
+                bp->setPending(true);
+                bp->setActionModify(true);
+            }
             emit publishBPState(*bp);
+            if (needDisable) {
+                bp->setPending(false);
+                bp->setActionModify(false);
+            }
             btr->setRow();
         }


[prev in list] [next in list] [prev in thread] [next in thread]