[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-bugs
Subject:    [Bug 91039] stopping the build doesn't stop the build
From:       kdevelop-bugs-admin () barney ! cs ! uni-potsdam ! de
Date:       2004-12-15 17:33:10
Message-ID: 20041215173310.26097.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=91039        
mattr kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mattr kde org  2004-12-15 18:33 -------
CVS commit by mattr: 

Run the make and it's children in their own process group. Fixes bug 91039

BUG: 91039


  M +3 -2      makewidget.cpp   1.112 [POSSIBLY UNSAFE: setUseShell]


--- kdevelop/parts/outputviews/makewidget.cpp  #1.111:1.112
 @ -181,5 +181,5  @ MakeWidget::MakeWidget(MakeViewPart *par
         mimeSourceFactory()->setImage("message", QImage((const char**)message_xpm));
 
-        childproc = new KShellProcess("/bin/sh");
+        childproc = new KProcess(this);
         procLineMaker = new ProcessLineMaker( childproc );
 
 @ -283,5 +283,6  @ void MakeWidget::startNextJob()
         childproc->clearArguments();
         *childproc << currentCommand;
-        childproc->start(KProcess::NotifyOnExit, KProcess::AllOutput);
+        childproc->setUseShell(true);
+        childproc->start(KProcess::OwnGroup, KProcess::AllOutput);
 
         dirstack.clear();


[prev in list] [next in list] [prev in thread] [next in thread]