From kdevelop Wed Jul 04 22:14:25 2001 From: Olaf Hartig Date: Wed, 04 Jul 2001 22:14:25 +0000 To: kdevelop Subject: bugs in template "KDE2 Normal" X-MARC-Message: https://marc.info/?l=kdevelop&m=99436326717251 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------Boundary-00=_24ZY36X8EX8DS4A2YDIV" --------------Boundary-00=_24ZY36X8EX8DS4A2YDIV Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Hello, I've found two bugs in the template "KDE2 normal app". It's in KDevelop 1.4 and in the latest CVS (KDEVELOP_1_4 branch) and may be in the HEAD branch (didn't checked it). They are in |Name|Doc::saveModified(). 1) The strings in the messagebox creation (KMessageBox::warningYesNoCancel) have to be exchanged, because we have the parameterlist parent, text, caption, ... and not parent, caption, text, ... 2) The values for the case statements are wrong. It has to be case 3: ...; break; case 4: ...; break; case 2: ...; break; Or better take the identifiers: case KMessageBox::Yes: ...; break; case KMessageBox::No: ...; break; case KMessageBox::Cancel: ...; break; I changed the according file ( ./skel/kbasedoc.cpp ) and attached it. Simply replace it in ./kdevelop/templates/normal2.tar.gz Please CC - I'm not on the list. Bye, Ole --------------Boundary-00=_24ZY36X8EX8DS4A2YDIV Content-Type: text/x-c++; charset="iso-8859-1"; name="kbasedoc.cpp" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kbasedoc.cpp" Ci8vIGluY2x1ZGUgZmlsZXMgZm9yIFF0CiNpbmNsdWRlIDxxZGlyLmg+CiNpbmNsdWRlIDxxd2lk Z2V0Lmg+CgovLyBpbmNsdWRlIGZpbGVzIGZvciBLREUKI2luY2x1ZGUgPGtsb2NhbGUuaD4KI2lu Y2x1ZGUgPGttZXNzYWdlYm94Lmg+CiNpbmNsdWRlIDxraW8vam9iLmg+CiNpbmNsdWRlIDxraW8v bmV0YWNjZXNzLmg+CgovLyBhcHBsaWNhdGlvbiBzcGVjaWZpYyBpbmNsdWRlcwojaW5jbHVkZSAi fE5BTUVMSVRUTEV8ZG9jLmgiCiNpbmNsdWRlICJ8TkFNRUxJVFRMRXwuaCIKI2luY2x1ZGUgInxO QU1FTElUVExFfHZpZXcuaCIKClFMaXN0PHxOQU1FfFZpZXc+ICp8TkFNRXxEb2M6OnBWaWV3TGlz dCA9IDBMOwoKfE5BTUV8RG9jOjp8TkFNRXxEb2MoUVdpZGdldCAqcGFyZW50LCBjb25zdCBjaGFy ICpuYW1lKSA6IFFPYmplY3QocGFyZW50LCBuYW1lKQp7CiAgaWYoIXBWaWV3TGlzdCkKICB7CiAg ICBwVmlld0xpc3QgPSBuZXcgUUxpc3Q8fE5BTUV8Vmlldz4oKTsKICB9CgogIHBWaWV3TGlzdC0+ c2V0QXV0b0RlbGV0ZSh0cnVlKTsKfQoKfE5BTUV8RG9jOjp+fE5BTUV8RG9jKCkKewp9Cgp2b2lk IHxOQU1FfERvYzo6YWRkVmlldyh8TkFNRXxWaWV3ICp2aWV3KQp7CiAgcFZpZXdMaXN0LT5hcHBl bmQodmlldyk7Cn0KCnZvaWQgfE5BTUV8RG9jOjpyZW1vdmVWaWV3KHxOQU1FfFZpZXcgKnZpZXcp CnsKICBwVmlld0xpc3QtPnJlbW92ZSh2aWV3KTsKfQp2b2lkIHxOQU1FfERvYzo6c2V0VVJMKGNv bnN0IEtVUkwgJnVybCkKewogIGRvY191cmw9dXJsOwp9Cgpjb25zdCBLVVJMJiB8TkFNRXxEb2M6 OlVSTCgpIGNvbnN0CnsKICByZXR1cm4gZG9jX3VybDsKfQoKdm9pZCB8TkFNRXxEb2M6OnNsb3RV cGRhdGVBbGxWaWV3cyh8TkFNRXxWaWV3ICpzZW5kZXIpCnsKICB8TkFNRXxWaWV3ICp3OwogIGlm KHBWaWV3TGlzdCkKICB7CiAgICBmb3Iodz1wVmlld0xpc3QtPmZpcnN0KCk7IHchPTA7IHc9cFZp ZXdMaXN0LT5uZXh0KCkpCiAgICB7CiAgICAgIGlmKHchPXNlbmRlcikKICAgICAgICB3LT5yZXBh aW50KCk7CiAgICB9CiAgfQoKfQoKYm9vbCB8TkFNRXxEb2M6OnNhdmVNb2RpZmllZCgpCnsKICBi b29sIGNvbXBsZXRlZD10cnVlOwoKICBpZihtb2RpZmllZCkKICB7CiAgICB8TkFNRXxBcHAgKndp bj0ofE5BTUV8QXBwICopIHBhcmVudCgpOwogICAgaW50IHdhbnRfc2F2ZSA9IEtNZXNzYWdlQm94 Ojp3YXJuaW5nWWVzTm9DYW5jZWwod2luLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGkxOG4oIlRoZSBjdXJyZW50IGZpbGUgaGFzIGJlZW4gbW9kaWZpZWQuXG4iCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiRG8geW91IHdhbnQg dG8gc2F2ZSBpdD8iKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp MThuKCJXYXJuaW5nIikpOwogICAgc3dpdGNoKHdhbnRfc2F2ZSkKICAgIHsKICAgICAgY2FzZSBL TWVzc2FnZUJveDo6WWVzOgogICAgICAgICAgIGlmIChkb2NfdXJsLmZpbGVOYW1lKCkgPT0gaTE4 bigiVW50aXRsZWQiKSkKICAgICAgICAgICB7CiAgICAgICAgICAgICB3aW4tPnNsb3RGaWxlU2F2 ZUFzKCk7CiAgICAgICAgICAgfQogICAgICAgICAgIGVsc2UKICAgICAgICAgICB7CiAgICAgICAg ICAgICBzYXZlRG9jdW1lbnQoVVJMKCkpOwogICAgICAgCSAgIH07CgogICAgICAgCSAgIGRlbGV0 ZUNvbnRlbnRzKCk7CiAgICAgICAgICAgY29tcGxldGVkPXRydWU7CiAgICAgICAgICAgYnJlYWs7 CgogICAgICBjYXNlIEtNZXNzYWdlQm94OjpObzoKICAgICAgICAgICBzZXRNb2RpZmllZChmYWxz ZSk7CiAgICAgICAgICAgZGVsZXRlQ29udGVudHMoKTsKICAgICAgICAgICBjb21wbGV0ZWQ9dHJ1 ZTsKICAgICAgICAgICBicmVhazsKCiAgICAgIGNhc2UgS01lc3NhZ2VCb3g6OkNhbmNlbDoKICAg ICAgICAgICBjb21wbGV0ZWQ9ZmFsc2U7CiAgICAgICAgICAgYnJlYWs7CgogICAgICBkZWZhdWx0 OgogICAgICAgICAgIGNvbXBsZXRlZD1mYWxzZTsKICAgICAgICAgICBicmVhazsKICAgIH0KICB9 CgogIHJldHVybiBjb21wbGV0ZWQ7Cn0KCnZvaWQgfE5BTUV8RG9jOjpjbG9zZURvY3VtZW50KCkK ewogIGRlbGV0ZUNvbnRlbnRzKCk7Cn0KCmJvb2wgfE5BTUV8RG9jOjpuZXdEb2N1bWVudCgpCnsK ICAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAgLy8g VE9ETzogQWRkIHlvdXIgZG9jdW1lbnQgaW5pdGlhbGl6YXRpb24gY29kZSBoZXJlCiAgLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIG1vZGlmaWVkPWZh bHNlOwogIGRvY191cmwuc2V0RmlsZU5hbWUoaTE4bigiVW50aXRsZWQiKSk7CgogIHJldHVybiB0 cnVlOwp9Cgpib29sIHxOQU1FfERvYzo6b3BlbkRvY3VtZW50KGNvbnN0IEtVUkwmIHVybCwgY29u c3QgY2hhciAqZm9ybWF0IC8qPTAqLykKewogIFFTdHJpbmcgdG1wZmlsZTsKICBLSU86Ok5ldEFj Y2Vzczo6ZG93bmxvYWQoIHVybCwgdG1wZmlsZSApOwogIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICAvLyBUT0RPOiBBZGQgeW91ciBkb2N1bWVudCBv cGVuaW5nIGNvZGUgaGVyZQogIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8KCiAgS0lPOjpOZXRBY2Nlc3M6OnJlbW92ZVRlbXBGaWxlKCB0bXBmaWxlICk7 CgogIG1vZGlmaWVkPWZhbHNlOwogIHJldHVybiB0cnVlOwp9Cgpib29sIHxOQU1FfERvYzo6c2F2 ZURvY3VtZW50KGNvbnN0IEtVUkwmIHVybCwgY29uc3QgY2hhciAqZm9ybWF0IC8qPTAqLykKewog IC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICAvLyBU T0RPOiBBZGQgeW91ciBkb2N1bWVudCBzYXZpbmcgY29kZSBoZXJlCiAgLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwoKICBtb2RpZmllZD1mYWxzZTsKICBy ZXR1cm4gdHJ1ZTsKfQoKdm9pZCB8TkFNRXxEb2M6OmRlbGV0ZUNvbnRlbnRzKCkKewogIC8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICAvLyBUT0RPOiBB ZGQgaW1wbGVtZW50YXRpb24gdG8gZGVsZXRlIHRoZSBkb2N1bWVudCBjb250ZW50cwogIC8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KCn0K --------------Boundary-00=_24ZY36X8EX8DS4A2YDIV-- - to unsubscribe from this list send an email to kdevelop-request@kdevelop.org with the following body: unsubscribe »your-email-address«