[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdelibs-bugs
Subject:    [frameworks-kwallet] [Bug 351056] useless migration wizard
From:       Valentin Rusu <kde () rusu ! info>
Date:       2015-08-07 16:18:11
Message-ID: bug-351056-90985-G5bwV6CyhJ () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=351056

--- Comment #4 from Valentin Rusu <kde@rusu.info> ---
(In reply to Harald Sitter from comment #3)
> Regarding the message box, I think even a notification is not necessary for
> the migration. It should  "just work". The user doesn't really need to know
> about this if everything goes according to plan and the migration works. If
> the migration fails however it would absolutely make sense to show a
> notification that allows the user to inspect the problem (look at the log
> view?) and/or file a bug etc.

Ok for that, makes sense.

> Also I just noticed that this wizard essentially renders kwallet-pam user
> experience broken on systems with both kwallet4 and kwallet5.
> In order to allow existing wallets to migrate I understand that kwallet5
> must be started after kwallet4, 

That's not exact. The migration wizard actually handles kwalletd4 start via
QDBusConnection::startService()

> so kwallet-pam systems would *always* run
> into the launchpad bug I mentioned above where kwalletd5 wants to migrate an
> empty wallet for new users.

That's not exact because of what I pointed-out just before.

> With kwallet-pam being part of Plasma 5.4 we really need to get this fixed
> as soon as possible to not have problems with the user experience for too
> long :/

User experience is important, that's true. However, kwallet-pam have some
design flaws that creates some problems here. For instance, it assumes user
only has one wallet, always named "kdewallet". See BUG:334373 for more
information. 

On the other hand, the migration wizard gracefully enumerates old wallets and
attempt to re-create them with the same names. Users may be quite happy with
that, IMHO.

As a matter of fact, this request will lead to some hacky code in the migration
agent in order to adjust for the hard-coded wallet created by the pam module. 

Finally, I won't remove the migration wizard code. I'll introduce a
configuration flag allowing it to be brought back by the users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Kdelibs-bugs mailing list
Kdelibs-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdelibs-bugs

[prev in list] [next in list] [prev in thread] [next in thread]