[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 246130] New: hidden stateChanged() method
From:       Pedro Lopez-Cabanillas <pedro.lopez.cabanillas () gmail ! com>
Date:       2010-07-29 7:54:45
Message-ID: bug-246130-17878 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=246130

           Summary: hidden stateChanged() method
           Product: kdelibs
           Version: SVN
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: kdecore
        AssignedTo: kdelibs-bugs@kde.org
        ReportedBy: pedro.lopez.cabanillas@gmail.com


Version:           SVN (using Devel) 
OS:                Linux

Compiling any class inherited from KMediaPlayer::Player, gcc reports this
warning:

/usr/include/kxmlguiclient.h:326: warning: ‘virtual void 
KXMLGUIClient::stateChanged(const QString&, 
KXMLGUIClient::ReverseStateChange)' was hidden
/usr/include/KDE/KMediaPlayer/../../kmediaplayer/player.h:131: warning:    
by ‘void KMediaPlayer::Player::stateChanged(int)'

KParts::Part inherits from XMLGUIClient the stateChanged(const QString&,...) 
method, and KMediaPlayer::Player::stateChanged(int) is a signal.

The problem is that hiding the method stateChanged(QString&) prevents the KPart
to be able to use XMLGUI states.



Reproducible: Always

Steps to Reproduce:
compile any class derived from KMediaPlayer::Player.




Olivier Goffart provided a solution in k-c-d:

The 'workaround' is to explicitly hide or enable it back with the 'using' 
keyword

put 
using KXMLGUIClient::stateChanged;
in the protected section of the KMediaPlayer::Player class

this does not break BC

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]