[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-www
Subject:    Re: Patch for website menu
From:       Jason Bainbridge <jbainbridge () gmail ! com>
Date:       2005-09-16 13:41:46
Message-ID: d6491f480509160641763300f8 () mail ! gmail ! com
[Download RAW message or body]

On 9/16/05, Jason Bainbridge <jbainbridge@gmail.com> wrote:
> On 9/15/05, Martin Ellis <m.a.ellis@ncl.ac.uk> wrote:
> > (Reposting to a more appropriate list than kde-doc-english.
> > NB: I'm using php 4.4.)
> >
> > Hi,
> >
> > I've just been writing some instructions for the KOffice site
> > about how to test it without having to commit to svn, and noticed
> > that the menu doesn't seem to work properly.
> >
> > Looking at the code, I can't see how it could work on the KDE site
> > (although evidently it does).  In order to get it working here, I've had to
> > use the attached patch.
> >
> > The problem is that the menu.inc files look like this:
> >   $section =& $this->appendSection("Inform");
> >   $section->appendLink("Home","");
> > yet, appendSection doesn't seem to be returning a reference
> > on my machine, and the changes made by appendLink are then
> > performed on a copy.  End result: the menu sections are empty.
> >
> > The patch is the minimum required to get it working here.
> >
> > Here's the relevant section of the php manual.
> > http://www.php.net/manual/en/language.references.return.php
> >
> > Is this just down to some php version incompatibility?
> > Would it be OK to apply the patch?
> 
> Apologies for the delay in getting back to you, I'll look at the patch
> once I'm home tonight (unless someone else on the list beats me to it)
> and if there are no problems I will commit it.

Okay I'm not allowed to do any more emailing today as I'm obviously
missing things left, right and centre as Christoph had already
committed the patch before me sending this.; :)

Cheers,
-- 
Jason Bainbridge
http://kde.org - webmaster@kde.org
Personal Site - http://jasonbainbridge.com
_______________________________________________
kde-www mailing list
kde-www@kde.org
https://mail.kde.org/mailman/listinfo/kde-www

[prev in list] [next in list] [prev in thread] [next in thread]