[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: kioslave hardcoded path
From:       Albert Vaca <albertvaka () gmail ! com>
Date:       2016-12-28 23:30:42
Message-ID: CAAQViEvcunHvYvQMSZh-uQ_rAr1KB0s5npv9oaHe=jZUTwrhqw () mail ! gmail ! com
[Download RAW message or body]

Happy to know that an awesome app as Kdenlive will be soon available for
Windows users, good job! :D

Since it looks like you are not using Craft, what build method are you
using instead and why?

Also, to avoid this kind of problems in thr future, are the patches that
Craft applies to qtbase something that can't be patched upstream? Or are we
just waiting for a new Qt release  that already has those patches applied?

On Dec 27, 2016 9:06 PM, "Kevin Funk" <kfunk@kde.org> wrote:

On Tuesday, 27 December 2016 20:44:48 CET Jean-Baptiste Mardelle wrote:
> On Tuesday, December 27, 2016 8:29:27 PM CET, Kevin Funk wrote:
> > On Tuesday, 27 December 2016 20:15:54 CET Kevin Funk wrote:
> >> On Tuesday, 27 December 2016 00:30:32 CET Jean-Baptiste
> >> Mardelle wrote: ...
>
> Thanks a lot for your answer.
>
> > Just noticed: The way you're starting the KIO slaves is the one
> > going through
> > DBus+klauncher. If that's actually intended, then you might need to
patch
> > stuff in kinit.git -- so far everyone avoid DBus+klauncher on
> > Windows for good
> > reasons.
>
> Yes, that's correct. We use DBus to communicate between the main
> application and the rendering process. It seems to work, but I was not
> aware of these KIO slaves issues.
>
> > Let me elaborate, there are two ways to start kio slaves:
> > a) KIO asks klauncher via DBus to launch KIO processes
> > b) KIO directly forks off KIO processes
> >
> > (a) is chosen if an available DBus session is detected, (b) is the
> > fallback.
> >
> > To *always* use (b), you have two options:
> > - Make sure there's no DBus session (or dbus-daemon.exe available to
start
> > one)
> >
> > - Set the KDE_FORK_SLAVES env var [1], this is what we do in KDevelop:
> >   https://cgit.kde.org/kdevelop.git/commit/?
> >
> > id=4a2f1c2457e0104eb9a6135649d3ce4dda312904
> >
> > (b) is the tested variant, which works fine for Kate/KDevelop/others...
>
> Using KDE Frameworks 5.29, currently with no install (everything inside a
> folder), and I can confirm that the KDE_FORK_SLAVES solution works.
>
> However, now a new terminal window (cmd.exe) opens everytime kioslave is
> called. Any idea haw to prevent that behavior ?

You need:
  https://codereview.qt-project.org/#/c/162585/

This patch is applied to the qtbase build when using KDE's Craft [1] --
which
is why we encourage using that one instead of other solutions. There are
more
patches in Craft for qtbase, for instance.

Regards,
Kevin


[1] https://community.kde.org/Craft

> Thanks a lot for taking the time to answer me, we are now very close to
> launch our Windows test version!
>
> Best regards
> Jean-Baptiste Mardelle
>
> > Hope that helps,
> > Kevin
> >
> >
> > [1] https://userbase.kde.org/KDE_System_Administration/
> > Environment_Variables#KDE_FORK_SLAVES
> >
> >> Yes, the installation path is compiled into the binary.
> >>
> >> Though kio looks into two other paths since quite some time now:
> >>   https://git.reviewboard.kde.org/r/125778/
> >>
> >> Are you using an outdated KF5 version? Or are you installing KF5 into a
> >> different prefix maybe? For the latter, you might need to
> >> tweak qt.conf, as ...


--
Kevin Funk | kfunk@kde.org | http://kfunk.org

[Attachment #3 (text/html)]

<div dir="auto"><div>Happy to know that an awesome app as Kdenlive will be soon \
available for Windows users, good job! :D</div><div dir="auto"><br></div><div \
dir="auto">Since it looks like you are not using Craft, what build method are you \
using instead and why?</div><div dir="auto"><br></div><div dir="auto">Also, to avoid \
this kind of problems in thr future, are the patches that Craft applies to qtbase \
something that can&#39;t be patched upstream? Or are we just waiting for a new Qt \
release   that already has those patches applied?<br><div class="gmail_extra" \
dir="auto"><br><div class="gmail_quote">On Dec 27, 2016 9:06 PM, &quot;Kevin \
Funk&quot; &lt;<a href="mailto:kfunk@kde.org">kfunk@kde.org</a>&gt; wrote:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div class="elided-text">On Tuesday, 27 December 2016 \
20:44:48 CET Jean-Baptiste Mardelle wrote:<br> &gt; On Tuesday, December 27, 2016 \
8:29:27 PM CET, Kevin Funk wrote:<br> &gt; &gt; On Tuesday, 27 December 2016 20:15:54 \
CET Kevin Funk wrote:<br> &gt; &gt;&gt; On Tuesday, 27 December 2016 00:30:32 CET \
Jean-Baptiste<br> &gt; &gt;&gt; Mardelle wrote: ...<br>
&gt;<br>
&gt; Thanks a lot for your answer.<br>
&gt;<br>
&gt; &gt; Just noticed: The way you&#39;re starting the KIO slaves is the one<br>
&gt; &gt; going through<br>
&gt; &gt; DBus+klauncher. If that&#39;s actually intended, then you might need to \
patch<br> &gt; &gt; stuff in kinit.git -- so far everyone avoid DBus+klauncher on<br>
&gt; &gt; Windows for good<br>
&gt; &gt; reasons.<br>
&gt;<br>
&gt; Yes, that&#39;s correct. We use DBus to communicate between the main<br>
&gt; application and the rendering process. It seems to work, but I was not<br>
&gt; aware of these KIO slaves issues.<br>
&gt;<br>
&gt; &gt; Let me elaborate, there are two ways to start kio slaves:<br>
&gt; &gt; a) KIO asks klauncher via DBus to launch KIO processes<br>
&gt; &gt; b) KIO directly forks off KIO processes<br>
&gt; &gt;<br>
&gt; &gt; (a) is chosen if an available DBus session is detected, (b) is the<br>
&gt; &gt; fallback.<br>
&gt; &gt;<br>
&gt; &gt; To *always* use (b), you have two options:<br>
&gt; &gt; - Make sure there&#39;s no DBus session (or dbus-daemon.exe available to \
start<br> &gt; &gt; one)<br>
&gt; &gt;<br>
&gt; &gt; - Set the KDE_FORK_SLAVES env var [1], this is what we do in KDevelop:<br>
&gt; &gt;     <a href="https://cgit.kde.org/kdevelop.git/commit/" rel="noreferrer" \
target="_blank">https://cgit.kde.org/kdevelop.<wbr>git/commit/</a>?<br> &gt; &gt;<br>
&gt; &gt; id=<wbr>4a2f1c2457e0104eb9a6135649d3ce<wbr>4dda312904<br>
&gt; &gt;<br>
&gt; &gt; (b) is the tested variant, which works fine for Kate/KDevelop/others...<br>
&gt;<br>
&gt; Using KDE Frameworks 5.29, currently with no install (everything inside a<br>
&gt; folder), and I can confirm that the KDE_FORK_SLAVES solution works.<br>
&gt;<br>
&gt; However, now a new terminal window (cmd.exe) opens everytime kioslave is<br>
&gt; called. Any idea haw to prevent that behavior ?<br>
<br>
</div>You need:<br>
   <a href="https://codereview.qt-project.org/#/c/162585/" rel="noreferrer" \
target="_blank">https://codereview.qt-project.<wbr>org/#/c/162585/</a><br> <br>
This patch is applied to the qtbase build when using KDE&#39;s Craft [1] -- which<br>
is why we encourage using that one instead of other solutions. There are more<br>
patches in Craft for qtbase, for instance.<br>
<br>
Regards,<br>
Kevin<br>
<br>
<br>
[1] <a href="https://community.kde.org/Craft" rel="noreferrer" \
target="_blank">https://community.kde.org/<wbr>Craft</a><br> <div \
class="quoted-text"><br> &gt; Thanks a lot for taking the time to answer me, we are \
now very close to<br> &gt; launch our Windows test version!<br>
&gt;<br>
&gt; Best regards<br>
&gt; Jean-Baptiste Mardelle<br>
&gt;<br>
&gt; &gt; Hope that helps,<br>
&gt; &gt; Kevin<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; [1] <a href="https://userbase.kde.org/KDE_System_Administration/" \
rel="noreferrer" target="_blank">https://userbase.kde.org/KDE_<wbr>System_Administration/</a><br>
 &gt; &gt; Environment_Variables#KDE_<wbr>FORK_SLAVES<br>
&gt; &gt;<br>
&gt; &gt;&gt; Yes, the installation path is compiled into the binary.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Though kio looks into two other paths since quite some time now:<br>
&gt; &gt;&gt;     <a href="https://git.reviewboard.kde.org/r/125778/" \
rel="noreferrer" target="_blank">https://git.reviewboard.kde.<wbr>org/r/125778/</a><br>
 &gt; &gt;&gt;<br>
&gt; &gt;&gt; Are you using an outdated KF5 version? Or are you installing KF5 into \
a<br> &gt; &gt;&gt; different prefix maybe? For the latter, you might need to<br>
&gt; &gt;&gt; tweak qt.conf, as ...<br>
<br>
<br>
</div><div class="elided-text">--<br>
Kevin Funk | <a href="mailto:kfunk@kde.org">kfunk@kde.org</a> | <a \
href="http://kfunk.org" rel="noreferrer" \
target="_blank">http://kfunk.org</a></div></blockquote></div><br></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic