[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 114476: Fix MSBuild of glib
From: Andrius da Costa Ribas <andriusmao () gmail ! com>
Date: 2016-04-22 19:42:29
Message-ID: 20160422194229.5099.6217 () mimi ! kde ! org
[Download RAW message or body]
--===============2589209390567254316==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114476/
-----------------------------------------------------------
(Updated Abril 22, 2016, 7:42 p.m.)
Status
------
This change has been discarded.
Review request for kdewin.
Repository: emerge
Description
-------
The patch currently being applied do not match the sources of 2.36.3. Also libintl \
headers and lib were not found so our include and lib dir needs to be added to \
%INCLUDE% and %LIB%, and /p:useenv=true needs to be passed to msbuild to make use of \
these environment variables.
Diffs
-----
portage/testing/glib-src/glib-2.36.3-20131215.diff PRE-CREATION
portage/testing/glib-src/glib-src-2.29.14.py a1f3cbd
Diff: https://git.reviewboard.kde.org/r/114476/diff/
Testing
-------
Builds and installs fine for MSVC.
For Intel Compiler, I'm figuring out a way to correctly determine the value in \
"/PlatformToolset=..." according to compiler version. Also the dependency libffi-src \
needs some fixes first.
Thanks,
Andrius da Costa Ribas
--===============2589209390567254316==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114476/">https://git.reviewboard.kde.org/r/114476/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Abril 22, 2016, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch currently being applied do not match the sources of 2.36.3. \
Also libintl headers and lib were not found so our include and lib dir needs to be \
added to %INCLUDE% and %LIB%, and /p:useenv=true needs to be passed to msbuild to \
make use of these environment variables.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and installs fine for MSVC. For Intel Compiler, I'm figuring \
out a way to correctly determine the value in "/PlatformToolset=..." \
according to compiler version. Also the dependency libffi-src needs some fixes \
first.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/testing/glib-src/glib-2.36.3-20131215.diff <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>portage/testing/glib-src/glib-src-2.29.14.py <span style="color: \
grey">(a1f3cbd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114476/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2589209390567254316==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic